Skip to content

lib/mux: receiveWindow 数据竞争导致并发短连接场景下 NPC panic #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
everhopingandwaiting wants to merge 1 commit into
base: master
Choose a base branch
from
Open

lib/mux: receiveWindow 数据竞争导致并发短连接场景下 NPC panic #368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/mux/conn_receive_window.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ type receiveWindow struct {
buffered uint32
count int8
sizeMu sync.Mutex
readMu sync.Mutex
bw *writeBandwidth
priority bool
once sync.Once
Expand Down Expand Up @@ -197,6 +198,8 @@ start:
}

func (Self *receiveWindow) Read(p []byte, id int32) (n int, err error) {
Self.readMu.Lock()
defer Self.readMu.Unlock()
if Self.IsClosed() {
return 0, io.EOF
}
Expand All @@ -218,7 +221,6 @@ copyData:
Self.element, err = Self.bufQueue.Pop()
Self.off = 0
if err != nil {
Self.CloseWindow()
return
}
}
Expand Down Expand Up @@ -282,6 +284,8 @@ func (Self *receiveWindow) CloseWindow() {
}

func (Self *receiveWindow) release() {
Self.readMu.Lock()
defer Self.readMu.Unlock()
for {
ele := Self.bufQueue.TryPop()
if ele == nil {
Expand Down