Skip to content

Remove duplicate PDF copies from project_packages - #109

Merged
dl1413 merged 2 commits into
mainfrom
chore/remove-duplicate-pdfs
Sep 29, 2026
Merged

dl1413 merged 2 commits into
mainfrom
chore/remove-duplicate-pdfs

Conversation

@dl1413

@dl1413 dl1413 commented Sep 29, 2026

Copy link
Copy Markdown
Owner

Each publication PDF existed twice (repo root and project_packages/). This keeps the root copies, which generate_publication_pdfs.py writes and scripts/validate_portfolio.py requires, and points each project page's PDF link at them.

scripts/validate_portfolio.py passes.

🤖 Generated with Claude Code

https://claude.ai/code/session_01W5HTneJKS5VFAzDE5sGDV9


Generated by Claude Code

Each publication PDF existed twice (repo root and project_packages/).
Keep the root copies, which the generator writes and the validator
requires, and point each project page's PDF link at them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W5HTneJKS5VFAzDE5sGDV9
Copilot AI balanced review requested due to automatic review settings September 29, 2026 01:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

The previous commit removed the duplicate PDFs but left these link
updates unstaged, so the project pages still pointed at the deleted
copies.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W5HTneJKS5VFAzDE5sGDV9

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

https://github.com/dl1413/Machine-Learning-Research-Engineering-Project-Profile/blob/f767ffd64a8af5bc07d7667806f2b4a2135f1216/project_packages/01_AI_Safety_RedTeam_Evaluation/AI_Safety_RedTeam_Evaluation_Publication.pdf#L1
P1 Badge Retarget PDF links before deleting package copies

When a reader opens any of the four project_packages/*/README.md pages, its publication link still points to ./<publication>.pdf, so these deletions make every project-page PDF link return a missing file even though copies remain at the repository root. This also causes python scripts/validate_portfolio.py to exit nonzero with four broken-link errors; update the links to the root copies (for example, ../../AI_Safety_RedTeam_Evaluation_Publication.pdf) or retain the package copies.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

dl1413 commented Sep 29, 2026

Copy link
Copy Markdown
Owner Author

Fixed in 2ba2c2a: the four project-page PDF links now point to the root copies (../../<publication>.pdf), and python scripts/validate_portfolio.py passes on the current head. The review was on f767ffd, before that commit.


Generated by Claude Code

@dl1413
dl1413 merged commit 99f364e into main Sep 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants