Repository navigation
test(omk-provider): assert x-should-retry=false on quota 429 - #458
Merged
Merged
Conversation
Follow up on QA's 11/18 checklist item 2: existing tests already show a quota 429 is sent once and not retried, but they did not assert that the rewritten response carries x-should-retry equal to "false".
Owner
Author
|
Reviewed head
No workflow rerun or merge was initiated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test-only follow-up to QA's 11/18 checklist item 2. Existing tests already show a monthly quota 429 (
quota_exceeded+x-omk-retryable: false) is sent once and not retried, but they did not assert that the rewritten response carriesx-should-retryequal to"false".Adds
packages/coding-agent/test/omk-provider-retry-header.test.tsonly. No source, golden, ormodels.generated.tschanges.The new file asserts:
x-omk-retryable: falseis rewritten withx-should-retryequal to"false".The inverse — a non-OMK call with
x-omk-retryable: falsedoes not getx-should-retryadded — is already covered inomk-provider-fetch-wrapper.test.ts(and the "leaves other fetch callers alone" case inomk-provider-gateway-errors.test.ts) and is not repeated here.Test plan
npx vitest --run test/omk-provider*inpackages/coding-agent— 18 files, 169/169 passed (was 17 files / 167 tests before this file).x-omk-retryable: false→x-should-retry: falsemapping is removed, then restored the source without committing that break.