Repository navigation
Conversation
…ols with 400 Built-in tools such as deepseek_web_search and deepseek_read_url are billed per call outside token metering. Reject any non-function tool or tool_choice before the upstream call (0 upstream calls, 0 usage rows). Matching is on the tool type, so a function tool named web_search still passes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per PM decision 2026-11-17 in the provider room.
toolsaccepts onlytype: "function"entries with a function name. Anything else (for exampledeepseek_web_search,deepseek_read_url) returns 400unsupported_toolbefore the upstream call. That means 0 upstream calls and 0usage_eventsrows.tool_choicemust betype: "function". String values (auto,none,required) pass as before.web_search(omk's local tool) still passes unchanged.image_input_unsupported), and unknown top-level params are already dropped by the allow-list.Stacked on
feat/omk-gateway-pg-race(which waits on #391). Onlygateway/src/validate.tsandgateway/test/params.test.tschange.Tests: 157 passed, 1 skipped (PGlite), including 6 new cases. Typecheck is clean.
Note:
tools: null(and any non-arraytools) now returns 400 as well. The omk client never sends it; kept as is for v1 (PM 2026-11-17).