Repository navigation
test(coding-agent): add unit tests for countOverlappingOccurrences - #466
Merged
dmae97 merged 1 commit intoNov 18, 2026
Merged
Conversation
4 tasks
dmae97
approved these changes
Nov 18, 2026
dmae97
left a comment
Owner
There was a problem hiding this comment.
Reviewed the single test-file addition at eac4e495. It covers all five cases from #462, including overlapping starts and the existing empty-needle behavior. I verified the five cases directly against the base source with Node assertions. The fork CI run is awaiting maintainer approval and is still required before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Adds direct unit tests for
countOverlappingOccurrencesinpackages/coding-agent/src/core/tools/edit-occurrences.ts. The helper is used by the edit tool to detect ambiguousoldText, but had no direct coverage. No source changes. Fixes #462.Verification
Result: 1 test file, 5 tests passed.
Checklist
npm run checkpasses locally (targeted vitest passes; full root check needs cargo for the native provider graph, which is not installed here)