You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test: add unit tests for warnDeprecation in utils/deprecation.ts (#464) - #467
Source review at c48d254c (no local execution; CI run 44217950241 is action_required, not a passing test run): warnDeprecation currently takes one argument, message: string, but every new call supplies two. Please pass the intended message as the single argument. The second argument is ignored at runtime and is a TypeScript arity error, so a targeted Vitest run alone would not establish that the root check passes.
Please also assert the complete expected text with toContain("Deprecation warning: Test deprecation message"), as #464 requests, instead of only checking the short key. Use the repository's .ts relative import convention and restore the console spy in afterEach so the final test does not leave it installed. Keep production source unchanged and provide both the focused test and root npm run check results after updating. Holding merge pending the corrected tests and verified CI.
The reason will be displayed to describe this comment to others. Learn more.
The new test calls do not match the one-argument warnDeprecation(message) signature on main. Please address the existing source review and update the PR head so it can be re-reviewed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #464. Adds unit tests for
warnDeprecationandclearDeprecationWarningsForTestsinpackages/coding-agent/test/deprecation.test.ts.