Skip to content

test: add unit tests for warnDeprecation in utils/deprecation.ts (#464) - #467

Merged
dmae97 merged 1 commit into
dmae97:mainfrom
arrafipd:fix/issue-464-deprecation-test
Nov 18, 2026
Merged

dmae97 merged 1 commit into
dmae97:mainfrom
arrafipd:fix/issue-464-deprecation-test

Conversation

@arrafipd

@arrafipd arrafipd commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Closes #464. Adds unit tests for warnDeprecation and clearDeprecationWarningsForTests in packages/coding-agent/test/deprecation.test.ts.

dmae97 commented Nov 18, 2026

Copy link
Copy Markdown
Owner

Source review at c48d254c (no local execution; CI run 44217950241 is action_required, not a passing test run): warnDeprecation currently takes one argument, message: string, but every new call supplies two. Please pass the intended message as the single argument. The second argument is ignored at runtime and is a TypeScript arity error, so a targeted Vitest run alone would not establish that the root check passes.

Please also assert the complete expected text with toContain("Deprecation warning: Test deprecation message"), as #464 requests, instead of only checking the short key. Use the repository's .ts relative import convention and restore the console spy in afterEach so the final test does not leave it installed. Keep production source unchanged and provide both the focused test and root npm run check results after updating. Holding merge pending the corrected tests and verified CI.

@dmae97 dmae97 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new test calls do not match the one-argument warnDeprecation(message) signature on main. Please address the existing source review and update the PR head so it can be re-reviewed.

@dmae97
dmae97 merged commit 3ebd3fb into dmae97:main Nov 18, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: add unit tests for warnDeprecation in utils/deprecation.ts

2 participants