Rename MTG to specMAGIC_MTG - #25
Merged
Merged
Conversation
irenelivia
approved these changes
Sep 14, 2026
irenelivia
left a comment
irenelivia
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for including specMAGIC in the data choices for clarity. I approve the renaming and suggest that all data choices be renamed at a later stage to account for KNMI and DWD datasets each having MSG and MTG options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@irenelivia correctly pointed out the the configurations added in #24 are not general to MTG but related to the specific output from specMAGIC for MTG data. As such, they have been renamed to reflect that.
The new dataset names are a bit long, but that is not necessarily an issue.