Skip to content

fix(e2e): stop the PSA sidecar guard passing when otel-collector is absent - #452

Open
AshrafAhmed9 wants to merge 2 commits into
documentdb:mainfrom
AshrafAhmed9:developer/e2e-otel-psa-assertion
Open

fix(e2e): stop the PSA sidecar guard passing when otel-collector is absent#452
AshrafAhmed9 wants to merge 2 commits into
documentdb:mainfrom
AshrafAhmed9:developer/e2e-otel-psa-assertion

fix(e2e): assert the otel-collector is injected, not just hardened

835a9f8
Select commit
Loading
Failed to load commit list.
DCO-2 / DCO required action Sep 5, 2026 in 0s

Check failed

There is one commit incorrectly signed off, the check did not pass.

Summary


Sha Message Pass or fail reason
🟢 0e7e2c6 fix(e2e): stop the PSA sidecar guard passing when ... Valid sign-off found
🔴 835a9f8 fix(e2e): assert the otel-collector is injected, n... Sign-off not found

Errors details

Sign-off not found

No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.

To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

How to fix missing or invalid sign-offs

Option 1: add remediation commit

Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.

Option 2: fix commits without sign-off

Amend last commit

To fix the incorrectly signed off commit:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git commit --amend --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin developer/e2e-otel-psa-assertion