Repository navigation
Add Rmv->glTF static exporter & texture handling - #314
Merged
Merged
Conversation
Add static RMV->glTF export support and expand texture/export tooling, UI and CI. Some parts of the render chain are rendered in separate non-destructive passes.
Key changes:
- Add new RmvToGltf static exporter pieces: GltfStaticMeshBuilder, GltfStaticExporter, view & viewmodel, AlphaMaskCombiner, MeshOptimizerStaticPose helper.
- Enhance GltfMeshBuilder: optional skeleton flag, robust handling/normalization of skin weights, default bindings for degenerate cases, and safer vertex handling.
- Extend GltfTextureHandler: new TextureResult/MaskTextureResult records, mask handling, alpha extraction, normal-map variants, displacement map export pipeline (offset/raw/16-bit options), Pfim-based DDS handling and integration with packfile service.
- Update DI: register static exporter, GltfStaticMeshBuilder and new services.
- DdsToNormalPngExporter: now outputs a raw PNG path ("_raw.png") and uses ImageSaveHandler; removed inline blue-normal conversion routine.
- Add AlphaMaskCombiner utility to merge diffuse + mask into an RGBA PNG.
- XAML: replace custom CachedTabControl with standard TabControl; add binding proxy resource, item style (drag/drop, middle-click close), and template cleanup/fixes for tab context menu and close button formatting.
- CI: expand pr-test workflow to run many individual project tests.
- Misc: small fixes (AnimationBinWh3 splice casting fix, csproj cleanup/added folders) and other editor additions (QuickExportPosedMeshCommand etc.).
These changes improve exporter robustness (static and skinned meshes), provide richer texture export options (masks, displacement, normal variants), and integrate exporters into DI and test pipelines.
Owner
|
In your merge, you removed quite a few bugfixes and new features. |
benMcChesney
marked this pull request as draft
April 3, 2026 20:48
Contributor
Author
|
I'll rework it into a cleaner branch of a newer version. Thanks for the feedback. |
Updated ToolTips to use localization and improved data binding for visibility.
donkeyProgramming
marked this pull request as ready for review
April 28, 2026 17:42
Contributor
Author
|
Hello,
Sorry for the late reply, I had some life stuff come up that kept me away
from this project for a bit. Thanks for merging the PR in , apologies I
wasn’t able to address the tests and merge issues myself. If there’s
anything I can do to give back please don’t hesitate to let me know.
Ben McChesney
…On Tue, Apr 28, 2026 at 10:48 AM donkeyProgramming ***@***.***> wrote:
Merged #314 <#314>
into master.
—
Reply to this email directly, view it on GitHub
<#314 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADJA6IQ7CKIRSBEPC3TCWL4YDVIFAVCNFSM6AAAAACW25KGCWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRUHE2TSNBZGU3DANI>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add static RMV->GLTF export support and expand texture/export tooling, UI and CI. Some parts of the render chain are rendered in separate non-destructive passes.
Key changes:
These changes improve exporter robustness (static and skinned meshes), provide richer texture export options (masks, displacement, normal variants), and integrate exporters into DI and test pipelines.