Remove legacy installer packaging - #12579
Open
jonathanpeppers wants to merge 2 commits into
Open
Conversation
Remove unused xbuild framework and legacy installer item lists now that workload packs consume only the current SDK packaging paths. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 58d497c1-701f-494b-b4d6-c26165da8799
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes legacy/unused installer packaging inputs from the build tooling, simplifying the installer item construction logic and cleaning up obsolete commentary in test infrastructure.
Changes:
- Removed obsolete Mono.Posix timestamp-related comment from
XamarinProject.UpdateProjectFiles. - Deleted legacy xbuild framework/MSBuild packaging properties, item lists, and targets from
create-installers.targets. - Simplified
ConstructInstallerItemsto only return the currentMSBuildItemsWin/MSBuildItemsUnixitem groups.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.ProjectTools/Common/XamarinProject.cs | Removes an obsolete comment related to historical file timestamp precision concerns. |
| build-tools/installers/create-installers.targets | Strips legacy installer/framework packaging logic and trims ConstructInstallerItems outputs to current pack inputs. |
Keep Mono.Android.Apis.projitems imported because Xamarin.Android.Build.Tasks consumes AndroidApiInfo when generating supported platform metadata. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 58d497c1-701f-494b-b4d6-c26165da8799
jonathanpeppers
added
the
ready-to-review
jonathanpeppers
enabled auto-merge (squash)
August 28, 2026 22:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create-installers.targetsMono.Posixtimestamp commentTesting
ConstructInstallerItemsfor Windows and Linuxcreate-installers.targetsas XML