Skip to content

Simplify Uninstall to fire-and-forget #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnkors merged 1 commit into from
Sep 13, 2026
Merged

Simplify Uninstall to fire-and-forget #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions source/src/Slackbot.Net.Endpoints/Configurations/IWorkspaceInstallationHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@ public interface IWorkspaceInstallationHandler

/// <summary>
/// Called when a workspace uninstalls your app or revokes its tokens.
/// Return the removed <see cref="Workspace"/>, or null if none was found for <paramref name="teamId"/>.
/// </summary>
Task<Workspace?> Uninstall(string teamId);
Task Uninstall(string teamId);
}

public record Workspace(string TeamId, string TeamName, string Token);
19 changes: 4 additions & 15 deletions source/src/Slackbot.Net.Endpoints/Middlewares/Uninstall.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,7 @@ public async Task Invoke(HttpContext context)
NullLogger<NoopWorkspaceInstallationHandler>.Instance);
var metadata = context.Items[HttpItemKeys.EventMetadataKey] as EventMetaData;
_logger.LogInformation($"Uninstalling team with TeamId: `{metadata.Team_Id}`");
var deleted = await installationHandler.Uninstall(metadata.Team_Id);
if (deleted is null)
{
_logger.LogWarning(
"Workspace installation handler returned null for '{TeamId}'.",
metadata.Team_Id);
}
else
{
_logger.LogInformation($"Uninstalled team with TeamId: `{metadata.Team_Id}`");
}

await installationHandler.Uninstall(metadata.Team_Id);
context.Response.StatusCode = 200;
}

Expand All @@ -48,10 +37,10 @@ public static bool ShouldRun(HttpContext ctx)

public class NoopWorkspaceInstallationHandler(ILogger<NoopWorkspaceInstallationHandler> logger) : IWorkspaceInstallationHandler
{
public Task<Workspace?> Uninstall(string teamId)
public Task Uninstall(string teamId)
{
logger.LogDebug("No-op. Returning null for uninstalling workspace!");
return Task.FromResult<Workspace?>(null);
logger.LogDebug("No-op. Not removing workspace!");
return Task.CompletedTask;
}

public Task Install(Workspace workspace)
Expand Down
7 changes: 3 additions & 4 deletions source/test/Slackbot.Net.SlackClients.Http.Tests/WorkspaceInstallationHandlerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,12 @@ public async Task FreshImplementerOfIWorkspaceInstallationHandlerWorks()
var freshHandler = Assert.IsType<FreshHandler>(handler);

await handler.Install(new Workspace("T1", "Team", "tok"));
var deleted = await handler.Uninstall("T1");
await handler.Uninstall("T1");

Assert.Single(freshHandler.Installed);
Assert.Equal("T1", freshHandler.Installed[0].TeamId);
Assert.Single(freshHandler.Uninstalled);
Assert.Equal("T1", freshHandler.Uninstalled[0]);
Assert.Equal("T1", deleted.TeamId);
}

private sealed class FreshHandler : IWorkspaceInstallationHandler
Expand All @@ -38,10 +37,10 @@ public Task Install(Workspace slackTeam)
return Task.CompletedTask;
}

public Task<Workspace> Uninstall(string teamId)
public Task Uninstall(string teamId)
{
Uninstalled.Add(teamId);
return Task.FromResult(new Workspace(teamId, "Team", "tok"));
return Task.CompletedTask;
}
}
}
Loading