feat: round-trip the oauth state to the success page - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SuccessRedirectUri. Closes Distribution middleware drops the OAuth state parameter #47.statethe app sent now comes back to that app's own success page as?state=, so the page can act on it however it likes.stateis opaque by definition — only the app that minted it knows whether it holds a return path, an encoded payload or a CSRF nonce — so interpreting it in a library would be guessing at another app's data.statefor CSRF sees no behaviour change at all.stateitself. That approach needs anIsLocalUrlguard to stay safe, and still misreads a base64 CSRF nonce that happens to begin with/— roughly one install in sixty-four for an app using one — as a path to redirect to.