Repository navigation
Conversation
Remove the deprecated husky.sh header from the pre-commit hook and switch the prepare script to the v9 form. Rename the stylelint-scss rule to load-no-partial-leading-underscore. Replace deprecated CSS flagged by the new config: word-break: break-word becomes overflow-wrap: anywhere, the clip fallback is dropped from the visually-hidden placeholder, and stylelint's autofixes for word-wrap, grid-gap, and rgba() are included.
The @crocsx/scss-to-json package is unmaintained and calls the legacy Sass JS API, which prints a deprecation warning on every run. The new scripts/tokenize.js reads the variables partial through the modern compileString API and emits the same JSON keys in the same order. Values are no longer minified, so the font stack keeps spaces after commas and the border widths keep their leading zero. Adds sass as a direct devDependency.
ESLint 10 no longer reads .eslintrc, so eslint.config.js carries the same setup: recommended core rules, no-unsanitized DOM rules, Prettier as a lint rule, and the xss location-href rule. Browser scripts in assets keep script mode and browser globals; build scripts in scripts get CommonJS mode and Node globals. Adds @eslint/js and globals, which ESLint no longer bundles, and widens the prettier and eslint npm scripts to cover scripts/*.js. Prettier 3 adds two trailing commas to navigation.js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Major-version bumps for the npm toolchain, plus the config changes those versions require so the pre-commit hook and
npm testpass again.Dependency bumps (package.json): ESLint 8 to 10, Prettier 2 to 3, pretty-quick 3 to 4, husky 8 to 9, stylelint 15 to 17, stylelint-scss 5 to 7, stylelint-config-standard 33 to 40, stylelint-config-standard-scss 9 to 17, and the related stylelint plugins.
Husky 9. The pre-commit hook drops the deprecated
husky.shheader, and thepreparescript uses the v9 form.Stylelint 17. The stylelint-scss rule
at-import-no-partial-leading-underscorewas renamed toload-no-partial-leading-underscore. The new config also flags two deprecated CSS values, resolved as follows:word-break: break-wordbecomesoverflow-wrap: anywherein table cells and the%u-word-wrapplaceholder.clipfallback is removed from%u-visually-hidden.clip-path: inset(100%)stays, and every browser in the current browserslist supports it.word-wraptooverflow-wrap,grid-gaptogap, andrgba()torgb().scss-to-json replaced.
@crocsx/scss-to-jsonis unmaintained and uses the legacy Sass JS API, which warns on every run.scripts/tokenize.jsreads the variables partial through the moderncompileStringAPI and emits the same JSON keys in the same order. Values are no longer minified, so the font stack gains spaces after commas and the border widths gain a leading zero.sassis now a direct devDependency.ESLint 10.
.eslintrcis migrated toeslint.config.jswith the same rules: recommended core rules, no-unsanitized DOM rules, Prettier as a lint rule, and the xss location-href rule. Adds@eslint/jsandglobals, which ESLint no longer bundles. Theprettierandeslintnpm scripts now also coverscripts/*.js.Not changed
Dart Sass warns that
@importis deprecated. The site builds with the github-pages gem, which pins Ruby Sass 3.7 and has no@usesupport, so the partials keep@importuntil the build moves off that gem.Testing
npm run stylelint,npm run js, and the pre-commit hook all exit 0 with no deprecation output.bundle exec jekyll buildcould not be run locally because the github-pages gems are not installed under the current Ruby; CI covers that step.