fix(e2e): poll the live tool count instead of reading it once - #530
Merged
Merged
Conversation
"list -> open the MCP server lands on Connect with URL, probe and live count" fails on develop with Expected: 22, Received: 6. The header chip renders as soon as the editor does, showing the count the store can compute before the backend-services fetch has landed — globals and custom tools only. The test read it once, with textContent(), and compared that first paint against the settled model, so it raced the fetch and lost. The Tools tab tests do not hit this because openToolsTab() waits for .mcp-tools-loading to clear first. Read the chip through expect.poll so the assertion retries until the catalog arrives, and assert the model is non-trivial separately rather than inferring it from the racing read. numberFrom() is left alone for the callers that read values which are settled by the time they run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"list -> open the MCP server lands on Connect with URL, probe and live count" fails on develop with Expected: 22, Received: 6.
The header chip renders as soon as the editor does, showing the count the store can compute before the backend-services fetch has landed — globals and custom tools only. The test read it once, with textContent(), and compared that first paint against the settled model, so it raced the fetch and lost. The Tools tab tests do not hit this because openToolsTab() waits for .mcp-tools-loading to clear first.
Read the chip through expect.poll so the assertion retries until the catalog arrives, and assert the model is non-trivial separately rather than inferring it from the racing read. numberFrom() is left alone for the callers that read values which are settled by the time they run.