Feat/mcp merged file tools UI - #531
Merged
Merged
Conversation
The MCP editor assumed merged tool_style applied to databases only, which was
true of the daemon until file services gained merged registration. With that
support in place the editor disagrees with the server: on a service exposing
three databases and three file services it reports 47 tools while the daemon
advertises 35, and the tool grid still labels the file rows logs_list_files
when a client is served a bare list_files.
Five places carried the assumption:
- effectiveTools() summed file verbs per service unconditionally, so the
Tools tab over-counted by (services - 1) x 6. It now branches on style the
way the database count already does.
- the write math counted file write verbs as per-service instances in both
styles; merged now counts the distinct verb set, matching databases.
- the tool grid resolved the emitted name with style for databases and a
hardcoded 'prefixed' for file services.
- the merged caption, which explains that turning a verb off narrows the
tool's allowed services rather than removing it, was gated to databases.
- the preview pane listed file tools under per-service names always, and the
custom-tool dialog reserved only prefixed file names, so a custom tool
could collide with a merged file verb without being flagged.
disabled_tools keys stay in the prefixed {service}_{verb} form in both styles,
so the store's write path is unchanged; this is presentation and arithmetic.
Note for review: the Appendix A write-tool test asserted file services were
per-service instances in BOTH styles. That invariant is what changed, so the
test now asserts 3 merged and 6 prefixed for two file services.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.