Repository navigation
feat: w:cantSplit on table rows and w:keepLines on paragraphs (#3, conflict resolved) - #5
Merged
Merged
Conversation
A list item's numPr was prefixed onto the finished w:pPr string, right after pStyle. CT_PPrBase is a sequence, so numPr must follow keepNext, keepLines and pageBreakBefore. renderParagraphProperties() now takes the numPr and writes it at its position. Output is unchanged today; it keeps the order valid once those elements are written.
ParagraphStyle::$keepWithNext was read from DOCX and serialized to HTML (break-after: avoid) but never written by the Word2007 writer. It is now written in CT_PPrBase order: after pStyle, before numPr and pBdr.
TableRow::$cantSplit / TableRowBuilder::cantSplit() and ParagraphStyle::$keepLines are written by the Word2007 writer (keepLines after keepNext and before numPr and pBdr; cantSplit first in w:trPr), read back by TableReader / OoxmlPropertyParser, and serialized to HTML as break-inside: avoid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries #3 by @serpentblade unchanged (three commits, authorship kept) plus one merge of
mainthat joins the two[Unreleased]sections ofCHANGELOG.md— #3 and #4 each opened their own. The fork does not allow maintainer edits, so the resolution lives here; merging this PR marks #3 as merged.composer stan: no errors🤖 Generated with Claude Code