Scope Skill Forge PR deduplication to target repository - #47
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes consistently scope catalog generation to the target repository, update documentation accordingly, and add focused regression tests for the new behavior.
Review tier: Lite
Findings: None
What changed in this PR
This PR scopes Skill Forge proposal deduplication and related-PR discovery to the intended target repository by requiring repository identity in PR search results, filtering out foreign-repo PRs before parsing markers, and erroring on marked PRs that lack repository identity.
Changes:
- Updated
proposal-ledger.pycatalog building to require a--repositorytarget, derive/validate PR repository identity, and filter foreign PRs before marker parsing. - Updated skill policy documentation to require
repo:owner/name-scoped searches and pass the target repository into the catalog builder. - Added regression tests covering foreign-repo PR filtering and rejection of marked PRs without repository identity.
| File | Description |
|---|---|
plugins/repo-dreamer/skills/repository-skill-forge/scripts/proposal-ledger.py |
Adds repository identity extraction + target-repo filtering and makes catalog generation require the target repository. |
plugins/repo-dreamer/skills/repository-skill-forge/SKILL.md |
Documents repo-scoped PR searching and the new --repository argument when building the proposal catalog. |
plugins/repo-dreamer/skills/repository-skill-forge/tests/test_stateless_forge.py |
Updates existing catalog tests for repository identity and adds regression coverage for cross-repo/malformed inputs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the fix from github/copilot-dreaming-tasks#78 and addresses the unscoped deduplication problem tracked in github/copilot-dreaming-tasks#58.
Validation
python3 -m unittest discover -s plugins/repo-dreamer/skills/repository-skill-forge/tests