Repository navigation
Convenience trait implementations on Ident #93
Description
Activity
The ones missing now are
Fromand it's an explicit design decision ofproc_macrothe crate to always require spans to be specified when creating anIdent. I'd like to stick with that for now before we addFromimplementations which implicitly choose a span for youRegarding
AsRef: the compiler folks are not comfortable committing to an API that does &Ident ⟶ &str. rust-lang/rust#38356 (comment) explains.From: over time these spans will get more important and we would prefer to require them explicitly.Thank you for the explanation. I was just concerned about the effort needed to port from the old
proc-macro"e&synstack, but keeping API minimal is important too, so that's fine.I'm very sorry if this is the wrong place, but I'm updating a crate to use the latest version of
proc-macro2and I have a lot ofthe trait 'std::convert::From<std::string::String>' is not implemented for 'proc_macro2::Ident'errors occurring for lines likelet _name = Ident::from(format!("_{}", name.as_ref()));I understand I need to use to_string() before as_ref() but what can I do to fix the implementation?
Thanks! :)
I suppose
nameis anIdent. In that case, you can uselet _name = Ident::new(&name.to_string(), Span::call_site());
instead. Example on playground.
Reacted by Ferdia McKeoghThank you so much! :)
- Repository owner locked and limited conversation to collaborators
on Sep 3, 2022
Should
Identfromproc-macro20.4 have following trait implementations likeIdentfromsyn0.13?From<&'a str>;From<Cow<'a, str>>;From<String>;AsRef<str>(however this one makesimpl PartialEq<T: AsRef<str> + ?Sized>conflict withimpl PartialEq).Also in case of the last one, is a quote from: rust-lang/rust#50473
relevant here (as in
Ident::as_strbeing equivalent to<Ident as AsRef<str>>::as_ref)?