Repository navigation
Conversation
dwilding
enabled auto-merge (squash)
November 5, 2026 01:57
dwilding
disabled auto-merge
November 5, 2026 02:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with #137. jjx was unable to probe port 80 because it runs unprivileged, then mistakenly classified port 80 as busy. jjx can now tell the difference. Lack of privilege is ultimately not a problem because the Docker daemon has sufficient privilege to publish port 80.
This PR also adds
--stable-port 80to the functional test for httpbin-demo, which would have exposed the issue earlier. And I'm correcting the loopback address in the e2e tests.