Skip to content

fix(library): reject encoded control characters in station routes #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoangsvit merged 3 commits into from
Nov 10, 2026
Merged

fix(library): reject encoded control characters in station routes #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e196266
fix(library): reject encoded control characters in station routes
hoangsvit Nov 10, 2026
9758fa8
test(library): cover encoded control characters and valid station slug
hoangsvit Nov 10, 2026
098fb48
Merge branch 'staging' into fix/reject-control-characters-station-pat…
hoangsvit Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions tests/listening-library.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,3 +68,16 @@ test('encoded path validation preserves valid percent-encoded Unicode station sl
const valid = station('%E1%BB%95n-%C4%91%E1%BB%8Bnh');
assert.equal(rememberStation(emptyListeningLibrary(), valid, 'pause').lastStation?.url, valid.url);
});


test('rejects percent-encoded control characters in station slugs', () => {
for (const url of [
'/asia/viet-nam/radio%00test',
'/asia/viet-nam/radio%0Atest',
'/asia/viet-nam/radio%09test',
'/asia/viet-nam/radio%7Ftest',
]) {
assert.equal(rememberStation(emptyListeningLibrary(), { ...station('test'), url }, 'play').lastStation, null, url);
}
assert.equal(rememberStation(emptyListeningLibrary(), station('radio-1'), 'pause').lastStation?.url, '/asia/viet-nam/radio-1');
});
2 changes: 1 addition & 1 deletion utils/listening-library.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export function stationIdentity(value) {
try {
if (value.url.split('/').some(part => {
const decoded = decodeURIComponent(part);
return decoded === '.' || decoded === '..' || /[\\/?#]/.test(decoded);
return decoded === '.' || decoded === '..' || /[\\/?#\u0000-\u001f\u007f]/.test(decoded);
})) return null;
} catch { return null; }
if (typeof value.title !== 'string' || !value.title.trim()) return null;
Expand Down
Loading