Skip to content

feat(GSP1288): add Spanner vector search solution and full Hashnode guide - #47

Draft
hoangsvit wants to merge 5 commits into
mainfrom
scout/new-gsp1288-spanner-vector-search-20261030
Draft

hoangsvit wants to merge 5 commits into
mainfrom
scout/new-gsp1288-spanner-vector-search-20261030

Conversation

@hoangsvit

Copy link
Copy Markdown
Member

New lab / evidence

Scope

  • labs/GSP1288/lab.sh: complete standalone Spanner remote model, schema, ten original sample descriptions, Spanner service-agent IAM, vector generation and cosine search; idempotent checks, bounded retries, project/region discovery, NO_COLOR and FORCE_COLOR=1.
  • labs/GSP1288/HASHNODE.md: full Overview → Setup → Task 1–4 → Solution, manually reproducible SQL, four checkpoints, two-command Quick from main (only available after merge), Manual video placeholder and sources.
  • Copyright (c) 2026 ePlus.DEV | Unlicense. No credentials or fixed project/region. No images reused without verified permission.

Validation

  • Bash/ShellCheck: pending GitHub CI; local ShellCheck unavailable. Do not mark PASS until CI confirms.
  • SQL checked against the public Google Skills task statements and Google Cloud CLI documentation; not executed in a lab.
  • static validated only; runtime/grader unverified (pending CI static validation).
  • Original short product descriptions differ from the official lab's reference prose; reviewer must confirm that graders inspect schema/count rather than exact descriptions. Override MODEL_ID if the lab's supplied model differs from the default.

Test latest PR commit

Run only inside an authorized Google Skills Cloud Shell; this obtains the latest branch SHA each time, downloads a commit-pinned file (avoids stale branch CDN content), and records a SHA-specific log.

REPO="ePlus-DEV/storage"
BRANCH="scout/new-gsp1288-spanner-vector-search-20261030"
SHA="$(git ls-remote "https://github.com/$REPO.git" "refs/heads/$BRANCH" | awk '{print $1}')"
[[ -n "$SHA" ]] || { echo "Could not resolve PR branch SHA" >&2; exit 1; }
curl -fL --retry 3 "https://raw.githubusercontent.com/$REPO/$SHA/labs/GSP1288/lab.sh" -o lab-test.sh
set -o pipefail
FORCE_COLOR=1 bash lab-test.sh 2>&1 | tee "lab-GSP1288-${SHA:0:12}.log"

Review required

  1. Check current lab model identifier and remote-model DDL against grader.
  2. Check exact product data requirements (original descriptions are independently authored).
  3. Validate SQL execution, IAM propagation and four grader checkpoints in an authorized lab.
  4. Review Hashnode accuracy and publication separately; not published.
  5. No merge/auto-approval; base main, Draft only. No changes to existing labs.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Member Author

Static validation update (latest head f373698c8b6590ed00a8bace0ac2250b67257ecb)

  • Lab Script Health CI — PASS
  • Unit tests: PASS.
  • Changed-script Bash parsing and ShellCheck severity error: PASS.
  • static validated only; runtime/grader unverified.

The PR body still says CI pending because GitHub returned HTTP 422 while updating PR metadata. This comment records the successful latest-commit CI result; no code or existing lab was changed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant