Skip to content

fix(GSP182): align lab settings and verify load test deployment - #59

Merged
hoangsvit merged 6 commits into
mainfrom
fix/gsp182-lab-reliability-20261104
Nov 5, 2026
Merged

hoangsvit merged 6 commits into
mainfrom
fix/gsp182-lab-reliability-20261104

Conversation

@hoangsvit

Copy link
Copy Markdown
Member

Summary

  • Align fallback region/zone with supplied GSP182 lab instructions (us-east1 / us-east1-c), while respecting configured values.
  • Use gcloud storage for the lab sample; fail early if sample files are incomplete.
  • Validate App Engine Python 3.12 runtime and trust Cloud Build success instead of a potentially misleading registry listing.
  • Use the lab-aligned e2-medium GKE node type.
  • Wait for Locust master and workers to roll out; require 20 ready workers before reporting success.
  • Show the external Locust UI endpoint when available.

Validation

  • Reviewed script structure and revised commands against the user-provided GSP182 instructions.
  • Not executed in a live Cloud Shell/GSP182 lab; cluster and progress checks remain unverified.

Notes

  • Uses only the lab's own Google Cloud project when the student runs the script.
  • Draft PR for manual review; do not auto-merge.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 621a8932-0717-41d7-bbff-c927b9b41f74
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Copy link
Copy Markdown
Member Author

GSP182 live run: GKE location-policy blocker

Cloud Shell run confirmed the Docker image was pushed successfully via fallback (sha256:9be53ad...) and App Engine deployed. Cluster creation failed because us-east1-c violates constraints/gcp.resourceLocations on the temporary Qwiklabs project.

Updated script in commit 47ff3506b5645f17cd2d85afe7e59063ae94e5b0 to display the effective policy when readable and explain how to rerun with an allowed REGION / ZONE; the script deliberately does not alter organization policy or probe random zones. The allowed zone has not yet been confirmed. Keep PR as draft pending lab validation.

Copy link
Copy Markdown
Member Author

Confirmed allowed location from live GSP182 project

User retrieved effective constraints/gcp.resourceLocations. Explicit allowed values include us-central1, us-central1-a, us-central1-b, us-central1-c, and us-central1-f, whereas us-east1-c is not allowed. Updated fallback to us-central1 in commit de33274a710742e3f66bf4760f597dc17c95380b. Existing Cloud Shell configurations may still be set to us-east1; these must be overridden explicitly with REGION=us-central1 ZONE=us-central1-a or updated via gcloud config. GKE provisioning/Locust grading not yet validated.

Copy link
Copy Markdown
Member Author

New live blocker: missing node service account actAs permission

With location set to allowed us-central1-a, GKE cluster creation now fails: The user does not have access to service account 460645564337-compute@developer.gserviceaccount.com. Ask a project owner to grant ... iam.serviceAccountUser. This is distinct from the earlier Cloud Build IAM failure. Cluster does not exist, so get-credentials and kubectl cannot work.

Commit c501f45cbcf69ee5902c65d734316e1aecb27b84 updates the script to explain IAM vs resource-location failures and abort cleanly before kubectl. No broad IAM grants or org-policy changes are made automatically. Pending lab owner authorization or an approved node service account usable by the student.

@hoangsvit
hoangsvit marked this pull request as ready for review November 5, 2026 01:33
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@hoangsvit
hoangsvit merged commit 2a57677 into main Nov 5, 2026
3 checks passed
@hoangsvit
hoangsvit deleted the fix/gsp182-lab-reliability-20261104 branch November 5, 2026 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant