Repository navigation
✨ feat!: move to core-ddd 6.0 and publish through trusted publishing - #4
Merged
Merged
Conversation
The release job exchanges its OIDC token for a one-hour API key (NuGet/login) before semantic-release runs, instead of reading the long-lived NUGET_KEY secret. nuget.org's policy for this repository names release.yml and the nuget environment, and release-verify says so when the login gives no key.
eQuantic.Core.Application, eQuantic.Core.Exceptions and eQuantic.Core.Domain 4.0.0 -> 6.0.0, the core-ddd line built on eQuantic.Core.Data 7.0.
edgarmesquita
commented
Nov 14, 2026
edgarmesquita
left a comment
Contributor
Author
There was a problem hiding this comment.
Secondary review, round 1 (Antigravity), because Copilot can't be requested on this repository (GitHub accepted the request and dropped it, the timeline has no review_requested event).
No findings, with every changed file in full in the prompt. The review closes here.
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next link of the chain after eQuantic/core-ddd#3... trusted publishing for the release, and core-api on core-ddd 6.0.
Trusted publishing. Same change as core-ddd. The release job logs in to nuget.org with its OIDC token (
NuGet/login, pinned to v1.2.0) before semantic-release runs, and publishes with the one-hour key it gets back instead of theNUGET_KEYsecret. A failed login stops the run before anything is tagged. It needs a policy on nuget.org for this repository: owner eQuantic, repository core-api, workflowrelease.yml, environmentnuget.Dependencies.
eQuantic.Core.Application,eQuantic.Core.ExceptionsandeQuantic.Core.Domain(tests) move from 4.0.0 to 6.0.0. core-api never took 5.0, so this crosses two majors of core-ddd:EntityBase<TKey>compares by identity instead of by reference.DuplicateKeyExceptionat commit, for one).No code changes were needed. Restore takes core-ddd 6.0.0 from nuget.org, and build and tests pass on net8.0 and net10.0.
This should go out as a major too, since core-api hands core-ddd to its users and they get both changes through it.
Left alone here: the sample under
samples/still referencessrc/eQuantic.Core.DataModel, which f67be8c removed. It isn't in the solution, so neither CI nor this build compiles it.