Skip to content

✨ feat!: move to core-ddd 6.0 and publish through trusted publishing - #4

Merged
edgarmesquita merged 2 commits into
mainfrom
feat/core-ddd-6
Nov 14, 2026
Merged

edgarmesquita merged 2 commits into
mainfrom
feat/core-ddd-6

Conversation

@edgarmesquita

Copy link
Copy Markdown
Contributor

Next link of the chain after eQuantic/core-ddd#3... trusted publishing for the release, and core-api on core-ddd 6.0.

Trusted publishing. Same change as core-ddd. The release job logs in to nuget.org with its OIDC token (NuGet/login, pinned to v1.2.0) before semantic-release runs, and publishes with the one-hour key it gets back instead of the NUGET_KEY secret. A failed login stops the run before anything is tagged. It needs a policy on nuget.org for this repository: owner eQuantic, repository core-api, workflow release.yml, environment nuget.

Dependencies. eQuantic.Core.Application, eQuantic.Core.Exceptions and eQuantic.Core.Domain (tests) move from 4.0.0 to 6.0.0. core-api never took 5.0, so this crosses two majors of core-ddd:

  • 5.0: EntityBase<TKey> compares by identity instead of by reference.
  • 6.0: core-ddd moves to eQuantic.Core.Data 7.0, whose repositories change what some existing calls do (a duplicate key surfaces as DuplicateKeyException at commit, for one).

No code changes were needed. Restore takes core-ddd 6.0.0 from nuget.org, and build and tests pass on net8.0 and net10.0.

This should go out as a major too, since core-api hands core-ddd to its users and they get both changes through it.

Left alone here: the sample under samples/ still references src/eQuantic.Core.DataModel, which f67be8c removed. It isn't in the solution, so neither CI nor this build compiles it.

The release job exchanges its OIDC token for a one-hour API key (NuGet/login) before semantic-release runs, instead of reading the long-lived NUGET_KEY secret. nuget.org's policy for this repository names release.yml and the nuget environment, and release-verify says so when the login gives no key.
eQuantic.Core.Application, eQuantic.Core.Exceptions and eQuantic.Core.Domain 4.0.0 -> 6.0.0, the core-ddd line built on eQuantic.Core.Data 7.0.

@edgarmesquita edgarmesquita left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secondary review, round 1 (Antigravity), because Copilot can't be requested on this repository (GitHub accepted the request and dropped it, the timeline has no review_requested event).

No findings, with every changed file in full in the prompt. The review closes here.

@edgarmesquita
edgarmesquita merged commit c3cffcf into main Nov 14, 2026
10 checks passed
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants