Repository navigation
Conversation
…-runner-admission' into feature/2026-09-29/evals-cleanup-adapter-constructors
…-runner-admission' into feature/2026-09-29/evals-cleanup-adapter-constructors
…-runner-admission' into feature/2026-09-29/evals-cleanup-adapter-constructors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The evaluation adapter has one way to be built (evals value-audit cleanup Task_8).
reconstructand fourreconstruct_with_*variants). They repeated the checksvalidate_runtime_bindingalready does. Production keepsnew,new_with_bindingandreconstruct_with_binding, and tests now build a binding and use them.atomic_replace. Its four-attempt retry on Windows permission-denied is unchanged; the injectable persist closure and both before-persist hooks, used only by tests, are gone. One all-platform test keeps what matters: a failed write leaves the existing bytes and no temporary file.Five files, 412 fewer lines. All 15,601 strict values across nine raw pairs are equal against Task_7, and the eight protected hashes are exact. evals-reviewer APPROVED after running the embedded suite (106 tests) and the Qdrant service tests (6) independently.
Stacked on #78.
🤖 Generated with Claude Code