Skip to content

🔥 The evaluation adapter has one way to be built - #79

Open
ebigunso wants to merge 4 commits into
feature/2026-09-29/evals-cleanup-runner-admissionfrom
feature/2026-09-29/evals-cleanup-adapter-constructors
Open

ebigunso wants to merge 4 commits into
feature/2026-09-29/evals-cleanup-runner-admissionfrom
feature/2026-09-29/evals-cleanup-adapter-constructors

Conversation

@ebigunso

Copy link
Copy Markdown
Owner

The evaluation adapter has one way to be built (evals value-audit cleanup Task_8).

  • Removed: adapter constructors that only tests called or nothing called (the controllable-similarity variants, the frozen-embedding constructors, reconstruct and four reconstruct_with_* variants). They repeated the checks validate_runtime_binding already does. Production keeps new, new_with_binding and reconstruct_with_binding, and tests now build a binding and use them.
  • The identity registry saves through one atomic_replace. Its four-attempt retry on Windows permission-denied is unchanged; the injectable persist closure and both before-persist hooks, used only by tests, are gone. One all-platform test keeps what matters: a failed write leaves the existing bytes and no temporary file.
  • Typed adapter error enums consumed only by test downcasts become plain errors with the same messages. Types nothing references, a duplicate retry test and a child-process environment-redirect test for a variable nothing sets are gone.

Five files, 412 fewer lines. All 15,601 strict values across nine raw pairs are equal against Task_7, and the eight protected hashes are exact. evals-reviewer APPROVED after running the embedded suite (106 tests) and the Qdrant service tests (6) independently.

Stacked on #78.

🤖 Generated with Claude Code

…-runner-admission' into feature/2026-09-29/evals-cleanup-adapter-constructors
…-runner-admission' into feature/2026-09-29/evals-cleanup-adapter-constructors
…-runner-admission' into feature/2026-09-29/evals-cleanup-adapter-constructors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant