Skip to content

✨ The harness tells the library which notion is the character - #84

Open
ebigunso wants to merge 4 commits into
feature/2026-09-29/evals-cleanup-library-surfacesfrom
feature/2026-09-30/evals-self-identity
Open

ebigunso wants to merge 4 commits into
feature/2026-09-29/evals-cleanup-library-surfacesfrom
feature/2026-09-30/evals-self-identity

Conversation

@ebigunso

Copy link
Copy Markdown
Owner

The harness tells the library which notion is the character (pairs with library #174, prospective Task_1).

  • The library's facade constructors now take the character's own notion id, and a store refuses to reopen as a different self. The harness passes it everywhere it builds the facade.
  • The id is the scenario's authored character entity where one exists, through the same UUID-v5 mapping every notion uses, so the self is the stored notion. Otherwise it is a stable per-namespace id in a separate self domain, which adds no notion and no cue.
  • Restart, reattach and cleanup carry the same id, so the library's store check never trips by accident.
  • Run and measurement headers record self_notion_ids for each executed namespace.

In the library the identity reads only for the obligation direction report and the store check, so recall does not change. A full capture against the same library through a minimal constructor patch shows zero unaccounted differences across 3.07 million values in 11 raw pairs, beyond the new header field. Tests: 374 workspace and 6 Qdrant lifecycle. evals-reviewer APPROVED with no findings.

Builds only against library #174 and later.

Stacked on #83.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant