Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The rename is consistently applied, accurately documented, and covered for both returned and retained serialized causes.
Review effort: Balanced
Findings: None
What changed in this PR
Corrects stats projection failures so structured causes accurately report graph-read failures.
Changes:
- Renames both stats cause variants from
EndpointHydrationtoGraphRead. - Updates wire tokens, messages, tests, and documentation.
- Verifies currency lookup failures in returned and retained health causes.
| File | Description |
|---|---|
src/errors.rs |
Renames typed causes and updates conversion logic. |
src/usecases/stats_projection.rs |
Reports all projection graph-read failures consistently. |
src/usecases/remember.rs |
Tests currency failures and serialization tokens. |
tests/write_planning_tests.rs |
Updates integration expectations. |
README.md |
Documents graph-read failure reporting. |
docs/design/database/graph_schema_design.md |
Records the structured cause contract. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Owner
Author
|
Superseded by #150: this fix was merged into the stack there (with its reconciliation against the scene surfaces the stack added) and reviewed by both tiers. Closing at the decider's direction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to a Copilot finding on the merged #115.
When the currency query failed during stats projection, the structured cause said endpoint hydration had failed, although that read had already succeeded. ADR-I-0029 makes structured causes authoritative, so this was a false typed fact.
The fix is a rename, not a new variant:
EndpointHydrationbecomesGraphReadin bothStatsUpdateCauseandRetrievalStatsHealthCause, with the message and wire token to match. A consumer acts the same way on any failed graph read that feeds the projection, and the inner graph error already says which read failed.Evidence: the existing currency-failure regression now checks the returned and retained causes and both wire tokens. Internal Tier D review approved; fmt, check, clippy with warnings denied and the full test suite pass for the worker and independently for the reviewer.
This PR is outside the merges the decider pre-authorized and waits for approval.
🤖 Generated with Claude Code