Repository navigation
✂️ The scene slice keeps only what earns its place, and a participant named in a caller-built plan is reachable - #122
Open
ebigunso wants to merge 8 commits into
Conversation
Scene completion cleanup item 1. Retain Missing handling but keep public documentation and facade tests focused on producible states. Full four-gate validation follows the six-item round as dispatched. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Scene completion cleanup item 2. Link to the embedding definition and retain the commit-time invariant without restating other behavior. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Scene completion cleanup item 3. Keep raw candidates in trace and defer per-cue reach claims until admission floors give them meaning. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Scene completion cleanup item 4. Writes and retrieval normalize blank entries while preserving keyed or word-bearing participants exactly. Remove the rejection variants and exercise normalization through the facade. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Scene completion cleanup item 5. Carry embedding inputs into shared indexing, remove correction input sorting, and retain the fresh-cascade observer without positional-pairing assertions. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Scene completion cleanup item 6. Derive one stable Involves link when the episode or a same-plan observation has no link to that participant. Keep prepare-produced links unchanged and verify authored recall and idempotent replay on real stores. All four gates pass. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…6-09-21/scene-completion-cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completion cleanup of the scene plan (stacked on #121). The plan's standing condition is a value audit of every part at completion, review-driven additions included.
Removed or made smaller
Missingreport itself stays, since silently dropping a source would be a false claim.matches. It was the raw nearest-neighbour list taken before any verification or floor: any words reach something in a non-empty store, so the list implied familiarity the library cannot assert, and after a failed vector delete it could name a forgotten memory. A description is now reported as used for a content cue; per-cue reach returns with measured floors.Added: the one behavior the slice was missing
rememberderived the link. Commit now guarantees it, in the same graph batch, and derives nothing where a link already reaches that person, soremember's link set and the measured baselines do not move.Evidence: internal Tier D review approved after one finding (the pairing key), confirmed with its own probe on the real stores. fmt, check, clippy with warnings denied and the full suite pass for the worker and independently for the reviewer.
🤖 Generated with Claude Code