Skip to content

✂️ The scene slice keeps only what earns its place, and a participant named in a caller-built plan is reachable - #122

Open
ebigunso wants to merge 8 commits into
feature/2026-09-21/scene-on-retrievalfrom
feature/2026-09-21/scene-completion-cleanup
Open

ebigunso wants to merge 8 commits into
feature/2026-09-21/scene-on-retrievalfrom
feature/2026-09-21/scene-completion-cleanup

Conversation

@ebigunso

Copy link
Copy Markdown
Owner

Completion cleanup of the scene plan (stacked on #121). The plan's standing condition is a value audit of every part at completion, review-driven additions included.

Removed or made smaller

  • A test that built its state by writing beneath the facade: no public caller can make a source object go missing. The Missing report itself stays, since silently dropping a source would be a false claim.
  • A description's list of matches. It was the raw nearest-neighbour list taken before any verification or floor: any words reach something in a non-empty store, so the list implied familiarity the library cannot assert, and after a failed vector delete it could name a forgotten memory. A description is now reported as used for a content cue; per-cue reach returns with measured floors.
  • The rejection of a blank participant. A blank entry is the easiest value to build, and rejecting it cost the character the whole experience; it is dropped, on writes and retrievals alike, and everything else is stored as given.
  • Positional pairing of precomputed embeddings with their objects. Pairing is by object type, id and surface; an id alone is not an identity, because an episode and an observation may share one (found by the internal review, with a regression through the public facade).
  • Schema text that repeated the vector guide.

Added: the one behavior the slice was missing

  • A participant named by key in a caller-built plan was stored but never linked, so meeting that person later did not bring the memory back; only remember derived the link. Commit now guarantees it, in the same graph batch, and derives nothing where a link already reaches that person, so remember's link set and the measured baselines do not move.

Evidence: internal Tier D review approved after one finding (the pairing key), confirmed with its own probe on the real stores. fmt, check, clippy with warnings denied and the full suite pass for the worker and independently for the reviewer.

🤖 Generated with Claude Code

ebigunso and others added 8 commits September 21, 2026 07:24
Scene completion cleanup item 1. Retain Missing handling but keep public documentation and facade tests focused on producible states. Full four-gate validation follows the six-item round as dispatched.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Scene completion cleanup item 2. Link to the embedding definition and retain the commit-time invariant without restating other behavior.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Scene completion cleanup item 3. Keep raw candidates in trace and defer per-cue reach claims until admission floors give them meaning.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Scene completion cleanup item 4. Writes and retrieval normalize blank entries while preserving keyed or word-bearing participants exactly. Remove the rejection variants and exercise normalization through the facade.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Scene completion cleanup item 5. Carry embedding inputs into shared indexing, remove correction input sorting, and retain the fresh-cascade observer without positional-pairing assertions.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Scene completion cleanup item 6. Derive one stable Involves link when the episode or a same-plan observation has no link to that participant. Keep prepare-produced links unchanged and verify authored recall and idempotent replay on real stores. All four gates pass.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@ebigunso
ebigunso added this pull request to stack #149 September 22, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant