Repository navigation
🔎 The trace says how well each description matched, and the documents say what a description brings - #141
Open
ebigunso wants to merge 6 commits into
Conversation
…21/scene-trace-and-docs Co-Authored-By: Codex <noreply@openai.com>
ebigunso
changed the base branch from
feature/2026-09-21/scene-reminders
to
feature/2026-09-22/measured-floors
September 22, 2026 22:00
…kept Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…21/scene-trace-and-docs Co-Authored-By: Codex <noreply@openai.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The serde compatibility behavior violates repository policy, and several completion records are future-dated.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds per-scene-search trace diagnostics and documents description-based recall behavior.
Changes:
- Reports best scores, references, and omitted counts per scene search.
- Refactors vector-root construction while preserving untraced retrieval behavior.
- Updates retrieval documentation and closes the scene-words plan.
| File | Description |
|---|---|
tests/scene_reminder_tests.rs |
Adapts reminder assertions to search traces. |
src/usecases/retrieve/scene.rs |
Builds scene-search traces and candidate roots. |
src/usecases/retrieve.rs |
Consumes refactored roots and trace data. |
src/models/vector/candidate_record.rs |
Limits truncation helper to tests. |
src/memory/retrieval_turn_tests.rs |
Updates omission-count assertions. |
src/memory/retrieval_scene_tests.rs |
Tests scores, references, and trace-off equality. |
src/lib.rs |
Exports the new trace type. |
src/api/types/retrieval.rs |
Defines the scene-search trace API. |
src/api/types.rs |
Re-exports the trace type. |
src/adapters/qdrant/tie_closure.rs |
Rebuilds admitted canonical candidates. |
README.md |
Explains description recall behavior. |
docs/design/database/vector_payload_design.md |
Documents search surfaces and diagnostics. |
docs/design/database/schema_cheat_sheet.md |
Summarizes scene-surface retrieval. |
docs/coding-agent/plans/completed/v0-2-scene-words-plan.md |
Records plan completion. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| /// Participant words share one search and therefore one count. | ||
| #[serde(default, skip_serializing_if = "BTreeMap::is_empty")] | ||
| pub scene_cue_omitted_counts: BTreeMap<CueKind, usize>, | ||
| #[serde(default, skip_serializing_if = "Vec::is_empty")] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Scene-words plan Task_3, stacked on #137. This completes the plan's three tasks.
Evidence: Codex Tier D approved at
4cf9763(eight parent/final facade cases with literal trace-off equality; 457 tests); Claude Tier A approved at0e3ab9fwith wording changes, applied. Stacked PRs run no Rust CI; orchestrator gates pass.🤖 Generated with Claude Code