Repository navigation
Conversation
…2/time-recency Co-Authored-By: Codex <noreply@openai.com>
ebigunso
changed the base branch from
feature/2026-09-22/v0-2-time-plan
to
feature/2026-09-22/write-warnings
September 22, 2026 22:00
…2/time-recency Co-Authored-By: Codex <noreply@openai.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Critical reminder-boundary correctness and moderate provenance, serialization, and query-scaling issues remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds scene-time recency and explicit time-range retrieval, including lifecycle-aware graph traversal, public API support, tests, and documentation.
Changes:
- Adds recency and date-match retrieval cues, floors, tracing, and ranking.
- Extends graph authority and Oxigraph temporal selection.
- Expands temporal retrieval and reminder-boundary coverage.
| File | Review |
|---|---|
tests/scene_surface_tests.rs |
Updates recency cue expectations. |
tests/scene_reminder_tests.rs |
Expands reminder-boundary and root-limit coverage. |
tests/retrieval_scope_tests.rs |
Includes temporal graph roots. |
tests/retrieval_last_interaction_tests.rs |
Updates recent-episode expectations. |
src/usecases/retrieve.rs |
Implements temporal selection. Moderate: Time cues leak onto overlapping topic candidates before admission. |
src/usecases/remember.rs |
Updates graph test delegation. |
src/usecases/link.rs |
Updates graph test delegation. |
src/usecases/correct_forget.rs |
Updates graph test delegation. |
src/ports/graph_authority.rs |
Adds temporal queries and reminder filtering. Critical: Reminder-root matching ignores object type, allowing ID collisions to reopen episode history. |
src/policy/graph_expansion.rs |
Applies reminder-aware filtering. |
src/memory/write_turn_tests.rs |
Updates graph test infrastructure. |
src/memory/retrieval_turn_tests.rs |
Updates floor and cue expectations. |
src/memory/retrieval_time_tests.rs |
Adds temporal retrieval coverage. |
src/memory/retrieval_scene_tests.rs |
Reconciles scene behavior with recency. |
src/memory/retrieval_floor_tests.rs |
Covers temporal floor interactions. |
src/memory.rs |
Registers temporal tests and telemetry. |
src/lib.rs |
Exports TimeRange. |
src/api/types/retrieval.rs |
Adds temporal API and tracing. Moderate: Missing serde(default) breaks trace round-trips. Nit: Date-range Task_2 expands the stated Task_1 scope without corresponding evidence. |
src/api/types.rs |
Re-exports TimeRange. |
src/adapters/oxigraph/tests.rs |
Tests temporal selection and eligibility. |
src/adapters/oxigraph/sparql_selectors.rs |
Implements temporal SPARQL selection. Moderate: Unconditional recency requires an unbounded store-side scan/sort. |
src/adapters/oxigraph/embedded.rs |
Connects temporal selection to the graph port. |
README.md |
Documents temporal retrieval behavior. |
docs/coding-agent/plans/completed/v0-2-write-warnings-plan.md |
Normalizes a companion-repository path. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+216
to
+218
| && (!self.reminder_only | ||
| || object.object_type != ObjectType::Episode | ||
| || object.id == self.root_id) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Time plan Task_1, stacked on #138. It also merges the approved scene-words closeout, the cues eligibility fix and the plan reconciliation so the stack stays linear.
A person walking into a room in the evening already carries what they did lately, with nobody named and nothing said. Before this, a scene that gave only a time brought nothing at all.
Evidence: 461 tests; a 23-case witness through the public interface on the real stores, with every changed expectation listed and the parent parity controls passing. The companion evaluation repository's before/after measurement on the time family is running at this tip and its numbers, with their reading for the character, go into the worker report before this is called done.
🤖 Generated with Claude Code