Skip to content

✨ An old belief is held as old - #147

Open
ebigunso wants to merge 5 commits into
feature/2026-09-22/time-anniversaryfrom
feature/2026-09-22/time-age-of-support
Open

ebigunso wants to merge 5 commits into
feature/2026-09-22/time-anniversaryfrom
feature/2026-09-22/time-age-of-support

Conversation

@ebigunso

Copy link
Copy Markdown
Owner

Time plan Task_4, stacked on #146. Reporting only: nothing about what comes to mind changes.

When the character recalls something it believes, it now knows how long ago that belief was last supported by anything it lived through, so an old belief can be held as old and never dropped for being old.

  • Each admitted belief reports, with the trace off, the whole seconds between the scene's reference time and the latest experience that supports it: an observation's own time where it has one, otherwise its experience's scene time.
  • Only support at or before the reference time counts; forgotten sources do not; a belief with no experience behind it, or whose only support lies after the reference time, reports none, never zero.
  • It is computed from what the result already reads, before an observation is folded into its experience, so there is no second read.

At two fixed reference times the selection (ids, sections, order, scores) is identical to the parent; moving the reference time a month adds exactly a month to the reported age. This branch also merges the approved anniversary tie fix so the stack stays linear.

Evidence: 492 tests; orchestrator gates pass. Under the measurement rule this task changes no recall and is exempt; the time slice is measured once at its checkpoint. Review follows.

🤖 Generated with Claude Code

@ebigunso
ebigunso added this pull request to stack #149 September 22, 2026 22:00
…-22/time-age-of-support

Co-Authored-By: Codex <noreply@openai.com>
Copilot AI balanced review requested due to automatic review settings September 22, 2026 22:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The reviewed changes have no unresolved approval-blocking issues.

Review effort: Balanced
Findings: None

What changed in this PR

Adds support-age reporting for admitted beliefs without changing retrieval selection, ordering, or scoring.

Changes:

  • Computes age from the latest eligible supporting experience.
  • Exposes and documents seconds_since_support.
  • Adds coverage for suppression, future support, corrections, and timestamp fallbacks.
File Description
src/​usecases/​retrieve/​scene.rs Computes support ages from hydrated sources.
src/​usecases/​retrieve.rs Supplies the retrieval reference time.
src/​memory/​retrieval_scene_tests.rs Tests support-age behavior and lifecycle cases.
src/​api/​types/​retrieval.rs Adds the public support-age field.
README.md Documents support-age semantics.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants