Repository navigation
Conversation
…09-22/time-age-of-support
…-22/time-age-of-support Co-Authored-By: Codex <noreply@openai.com>
…-22/time-age-of-support Co-Authored-By: Codex <noreply@openai.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The reviewed changes have no unresolved approval-blocking issues.
Review effort: Balanced
Findings: None
What changed in this PR
Adds support-age reporting for admitted beliefs without changing retrieval selection, ordering, or scoring.
Changes:
- Computes age from the latest eligible supporting experience.
- Exposes and documents
seconds_since_support. - Adds coverage for suppression, future support, corrections, and timestamp fallbacks.
| File | Description |
|---|---|
src/usecases/retrieve/scene.rs |
Computes support ages from hydrated sources. |
src/usecases/retrieve.rs |
Supplies the retrieval reference time. |
src/memory/retrieval_scene_tests.rs |
Tests support-age behavior and lifecycle cases. |
src/api/types/retrieval.rs |
Adds the public support-age field. |
README.md |
Documents support-age semantics. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time plan Task_4, stacked on #146. Reporting only: nothing about what comes to mind changes.
When the character recalls something it believes, it now knows how long ago that belief was last supported by anything it lived through, so an old belief can be held as old and never dropped for being old.
At two fixed reference times the selection (ids, sections, order, scores) is identical to the parent; moving the reference time a month adds exactly a month to the reported age. This branch also merges the approved anniversary tie fix so the stack stays linear.
Evidence: 492 tests; orchestrator gates pass. Under the measurement rule this task changes no recall and is exempt; the time slice is measured once at its checkpoint. Review follows.
🤖 Generated with Claude Code