Deprecate withPhpCsFixerSets(), drop dynamic PHP-CS-Fixer set loading - #66
Merged
Conversation
Loading PHP-CS-Fixer rule sets dynamically was overkill; prepared sets cover the same ground. The method stays as a no-op that reports the deprecation, pointing users to withPreparedSets()/withSets(). Removes the dynamicSets plumbing, ECSConfig::dynamicSets(), the method generator script, and the tests that exercised the removed loading. Claude-Session: https://claude.ai/code/session_01A8hvNrf4ZxWkiEjWxecSAa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading PHP-CS-Fixer rule sets dynamically was overkill. Prepared sets cover the same ground with a simpler API.
What changed
withPhpCsFixerSets()is kept but reduced to a no-op that emits anE_USER_DEPRECATEDnotice, pointing users to->withPreparedSets()/->withSets().$dynamicSetsbuilder state,ECSConfig::dynamicSets(), and thebin/generate-php-cs-fixer-tests.phpgenerator.withPhpCsFixerSets(perCS20: ...)usage.Note
The method signature was stripped to no parameters, so existing calls passing named args will need to move to prepared sets.
phpstan, rector, check-cs and the full test suite pass.
https://claude.ai/code/session_01A8hvNrf4ZxWkiEjWxecSAa