Remove deprecated symplify set and withPreparedSets() symplify arg - #67
Merged
Conversation
The symplify set loaded no rules - it only emitted a deprecation notice. Its rules already live in the common sets. Claude-Session: https://claude.ai/code/session_01A8hvNrf4ZxWkiEjWxecSAa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up cleanup after deprecating the PHP-CS-Fixer set loading.
The
symplifyset was already a no-op:config/set/symplify.phpemitted a deprecation notice and returned->withRules([]), loading zero rules. Its rules already live in thecommonsets.What changed
symplifyargument (and its deadtrigger_errorblock) fromwithPreparedSets().SetList::SYMPLIFYconstant.config/set/symplify.php.Note
withPreparedSets(symplify: true)callers should switch to->withPreparedSets(common: true)or the matchingwith*Level()methods.phpstan, rector, check-cs and the full test suite pass.
https://claude.ai/code/session_01A8hvNrf4ZxWkiEjWxecSAa