Deprecate withEditorConfig(), drop EditorConfig support - #68
Merged
Conversation
EditorConfig discovery leaked project-wide settings (indent, line ending, quotes, final newline) into ECS, overriding the configured sets. The method now reports a deprecation warning; configure the matching PHP-CS-Fixer rules explicitly instead. Removes the EditorConfig value objects, factory, the builder wiring, and its test. Claude-Session: https://claude.ai/code/session_01A8hvNrf4ZxWkiEjWxecSAa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EditorConfig discovery leaked project-wide
.editorconfigsettings (indent style, end of line, max line length, trailing whitespace, final newline, quote type) into ECS, silently overriding the rules configured through sets. Coding standard should be driven by the ECS config, not by a file shared with other tooling.What changed
withEditorConfig()is kept but reduced to a deprecation warning (rendered viaOutputPrinter, same aswithPhpCsFixerSets()), pointing users to configure the matching PHP-CS-Fixer rules explicitly.applyEditorConfigSettings(), the$useEditorConfigstate and__invoke()wiring, and theConfiguration/EditorConfig/value objects + factory.EditorConfigFactoryTest.->withEditorConfig()call from this repo's ownecs.php.Note
Projects relying on
->withEditorConfig()should configure the equivalent PHP-CS-Fixer rules directly (indentation via->withSpacing(), line length viaLineLengthFixer, quotes viaSingleQuoteFixer, etc.).phpstan, rector, check-cs and the full test suite pass.
https://claude.ai/code/session_01A8hvNrf4ZxWkiEjWxecSAa