Make JSON output always report absolute paths, deprecate real path reporting - #70
Merged
Merged
Conversation
…porting Absolute paths are only useful for machine-consumed output, so the JSON formatter now always reports them. The other formatters stay relative. withRealPathReporting() and ECSConfig::reportingRealPath() are kept as deprecation warnings pointing to the JSON output format; the underlying reporting-realpath option and its plumbing are removed. Claude-Session: https://claude.ai/code/session_01A8hvNrf4ZxWkiEjWxecSAa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Absolute file paths in the report are only useful when the output is consumed by a machine (IDE links, CI code-quality ingestion). That is exactly what the JSON formatter is for, so it now always reports absolute paths - no toggle needed.
What changed
JsonOutputFormatteralways reports absolute paths.withRealPathReporting()andECSConfig::reportingRealPath()are kept as deprecation warnings pointing users to--output-format json.reporting-realpathplumbing:Option::REPORTING_REALPATH,Configuration::$reportingWithRealPath+isReportingWithRealPath(), and theConfigurationFactorywiring.->withRealPathReporting(false)call from the defaultconfig/config.php.Note
There was no
--reporting-realpathCLI flag; the option was only reachable through the config method, now deprecated.phpstan, rector, check-cs and the full test suite pass.
https://claude.ai/code/session_01A8hvNrf4ZxWkiEjWxecSAa