Add PER-CS 3.0 prepared set - #76
Merged
Merged
Conversation
Mirrors PHP-CS-Fixer @PER-CS3x0 (non-risky) as a native ECS prepared set. Reachable via SetList::PER_CS or withPreparedSets(perCs: true).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds native ECS support for the PER Coding Style 3.0.
Before this, PER-CS was only reachable through the deprecated
withPhpCsFixerSets(), which is now a no-op - so there was no way to apply PER-CS through ECS.What
config/set/per-cs.php- prepared set mirroring PHP-CS-Fixer@PER-CS3x0(non-risky rules only), expanded to individual fixer classes to match the existing prepared-set style.SetList::PER_CSconstant.withPreparedSets(perCs: true)flag.Reachable both ways:
Notes
@PER-CS3x0:risky) are intentionally left out.@PER-CS3x0resolution (rules + configs verified against the resolved ruleset). The official spec is now at 3.1, but php-cs-fixer does not yet ship a 3.1 set.Tests
Added
tests/Set/PerCs/PerCsTest.phpwith a fixture covering the 3.0 deltas (nullable type shorthand, short arrays, spacing, trailing commas).phpstan, rector, check-cs, and phpunit all pass locally.