[submodule] Advance sonic-ztp to pick up the port config re-assert fix - #738
Merged
gord1306 merged 1 commit intoAug 11, 2026
Merged
Conversation
sonic-ztp 89fd507 adds a re-assertion of the front panel port configuration at the end of ztp-profile.sh remove. Without it, the interfaces-config restart performed while tearing down the ZTP profile runs "ifdown -a" followed by "ifup -a" against a freshly regenerated /etc/network/interfaces that no longer contains any Ethernet stanza, because the ZTP in-band block of interfaces.j2 is gated on ZTP['mode'] and that table has just been deleted. Every front panel port that ifupdown2 had adopted for ZTP in-band DHCP is taken down and not brought back, leaving the netdev administratively down with its MTU reset to the kernel default while CONFIG_DB, APPL_DB and the ASIC all still report the port as up. portmgrd is event driven only and does not correct the drift, so the port stays down until something writes CONFIG_DB. Also point the src/sonic-ztp submodule branch at 202311.X_4630_10g_prod, which is the branch this pointer actually tracks. It was still set to 202311.X, so "git submodule update --remote" would have pulled from the wrong branch. Signed-off-by: gord_chen <gord_chen@edge-core.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
sonic-ztp89fd507 adds a re-assertion of the front panel port configuration at the end ofztp-profile.sh remove. This bumps the submodule so the fix is included in the build.Without it, the
interfaces-configrestart performed while tearing down the ZTP profile runsifdown -afollowed byifup -aagainst a freshly regenerated/etc/network/interfacesthat no longer contains any Ethernet stanza, because the ZTP in-band block ofinterfaces.j2is gated onZTP['mode']and that table has just been deleted.Every front panel port that ifupdown2 had adopted for ZTP in-band DHCP is therefore taken down and not brought back. The netdev is left administratively down with its MTU reset to the kernel default, while CONFIG_DB, APPL_DB and the ASIC all still report the port as up, so
show interfaces statuslooks healthy.portmgrdis event driven only and does not correct the drift, so the port stays down until something writes CONFIG_DB.What changed
The
.gitmodulesbranch field is a separate small correction: the pointer has been tracking202311.X_4630_10g_prodin practice, but the field still said202311.X, sogit submodule update --remotewould have pulled from the wrong branch.How to verify it
After building and installing, run inband ZTP to completion, then once ZTP has removed its profile:
Before the fix the second command drops to 0 while
show interfaces statusstill reports every port as up.Verified on a 54 port platform: the re-assertion issues 108
portmgrdre-applications, mtu and admin_status for each port, and completes in 1.8 seconds.Possible concerns
git submodule update --remote; the checked out commit is pinned by SHA either way, so existing builds are unaffected.