Skip to content

workers-stage.tf: fantasy-stage urls = true (step 3) - #669

Merged
ejc3 merged 1 commit into
mainfrom
fantasy-stage-urls
Oct 25, 2026
Merged

ejc3 merged 1 commit into
mainfrom
fantasy-stage-urls

Conversation

@ejc3

@ejc3 ejc3 commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

Step 3 for fantasy-stage, following #667, which adopted the Worker into the "Site staging Workers" Access application with its URLs off.

This turns on its workers.dev URL and version previews, https://fantasy-stage.cc-games.workers.dev. The Access application already covers the Worker, so both answer behind Access.

Once this is applied, ejc3/constellation sets workers_dev and preview_urls true in apps/fantasy-web/wrangler.jsonc, so the next deploy keeps them on. That change goes in only after the URL is seen to answer with the Access sign-in.

Summary by CodeRabbit

  • New Features
    • Fantasy-stage workers now have URL access enabled, making their endpoints available through the configured worker URLs. This change applies to the fantasy staging environment; it does not describe a change to other environments.

- Turns on fantasy-stage's workers.dev URL and version previews. The Site staging Workers Access
  application has covered the Worker since #667 (step 2), so both surfaces answer behind Access.
  ejc3/constellation sets workers_dev and preview_urls true in apps/fantasy-web/wrangler.jsonc
  once this is applied.
@ejc3
ejc3 marked this pull request as ready for review October 25, 2026 12:29
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 273de151-c7a8-4289-a16e-22fe749204cb
Commits

Reviewing files that changed from the base of the PR and between bae6c2e and c35856c.

Files selected for processing: 1
  • workers-stage.tf

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The Terraform configuration sets fantasy-stage URLs to true instead of false.

Changes: Stage URL setting

Layer / File(s) Summary
Enable fantasy-stage URLs
workers-stage.tf
The fantasy-stage setting changes from urls = false to urls = true.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Merge Risk: Minimal · up to c3585

The fantasy-stage URLs are covered by the existing Access policies; no merge-blocking risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the actual change: the fantasy-stage entry in workers-stage.tf switches from urls = false to urls = true. The raw summary confirms this one-line change, and the PR objectives describe …
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the actual change: the fantasy-stage entry in workers-stage.tf switches from urls = false to urls = true. The raw summary confirms this one-line change, and the PR objectives describe enabling the workers.dev URL and version previews for that Worker. The title is specific and matches the changeset. Its step-number suffix and file-name prefix are minor style points and do not affect the result.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T13:16:26.804348Z c35856c Manual request
🔒 Security Review ✅ Completed 2026-10-25T13:17:04.681736Z c35856c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

ejc3 commented Oct 25, 2026

Copy link
Copy Markdown
Owner Author

@codex review
@coderabbitai review
@greptileai review

ejc3 commented Oct 25, 2026

Copy link
Copy Markdown
Owner Author

@codex security review

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: c35856cfab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: c35856cfab

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@ejc3
ejc3 merged commit 9857d30 into main Oct 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant