Repository navigation
fcvm-fleet: the coordinator may read the host groups' scaling activities - #670
Conversation
ejc3/fcvm#1263 moves a wake to the on-demand host group as soon as Auto Scaling records a failed spot launch (UnfulfillableCapacity or MaxSpotInstanceCountExceeded, about 10 s after the raise), instead of after --spot-wait (120 s). It reads that from DescribeScalingActivities, which the coordinator's task role lacks; without it the coordinator logs the refusal once and keeps the spot wait. DescribeScalingActivities takes no resource-level permission, so it joins DescribeAutoScalingGroups on Resource "*". scripts/test-fcvm-fleet.py pins the action list. Tested: python3 scripts/test-fcvm-fleet.py (33 tests OK), terraform fmt -check.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 56 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
@codex security review |
|
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ejc3/fcvm#1263 moves a wake to the on-demand host group as soon as Auto Scaling records a failed spot launch (
UnfulfillableCapacity,MaxSpotInstanceCountExceeded; on staging that activity appears about 10 s after the coordinator raises the group), instead of after--spot-wait(120 s). It reads that fromDescribeScalingActivities, which the coordinator's task role lacks. Without the permission the coordinator logs the refusal once and keeps the spot wait, so this can be applied before or after the coordinator image that uses it.Change:
DescribeTheHostGroupsinfcvm-fleet.tfgainsautoscaling:DescribeScalingActivities. It takes no resource-level permission, so it sharesResource = "*"withDescribeAutoScalingGroups; it is read-only.Tested:
python3 scripts/test-fcvm-fleet.py(33 tests OK; the action list is pinned and the old assertion fails against the new statement),python3 scripts/test-fcvm-fleet-account.pyOK,terraform fmt -check.Part of ejc3/fcvm#1257.