Skip to content

Render the secondary IPv4 command without Python indentation - #672

Merged
ejc3 merged 1 commit into
mainfrom
fix-secondary-ipv4-command
Oct 25, 2026
Merged

ejc3 merged 1 commit into
mainfrom
fix-secondary-ipv4-command

Conversation

@ejc3

@ejc3 ejc3 commented Oct 25, 2026

Copy link
Copy Markdown
Owner

Fix the SSM command for #666: the nested Terraform heredoc double-indented the Python payload, so the association failed with IndentationError before configuring the host. Render a dedicated template whose script and closing delimiter begin at column zero.

The shell regression compiles the actual template's stdin and checks the address argument without running host networking commands. It fails without the template/wiring and all five secondary-address tests now pass. Terraform formatting and locked-provider validation pass. No network restart or address cutover is introduced.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3c08ba02-65f1-4d23-a0e5-077cef953d31
Commits

Reviewing files that changed from the base of the PR and between c309405 and 00b0916.

Files selected for processing: 3
  • firecracker-dev.tf
  • scripts/fcvm-secondary-ipv4-command.tftpl
  • scripts/test-fcvm-secondary-ipv4.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T12:58:26.514879Z 00b0916 Manual request
🔒 Security Review ✅ Completed 2026-10-25T12:59:57.978698Z 00b0916 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

ejc3 commented Oct 25, 2026

Copy link
Copy Markdown
Owner Author

@codex review
@coderabbitai review
@greptileai review

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

ejc3 commented Oct 25, 2026

Copy link
Copy Markdown
Owner Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 00b0916cc0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: 00b0916cc0

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@ejc3
ejc3 merged commit 3bfae30 into main Oct 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant