Repository navigation
dolphin-maps loops: monthly week and weekly weekend schedules on the sweep function - #673
Conversation
…ule on the sweep function
- dolphin-maps-loop.tf: eight more aws_scheduler_schedule resources
(dolphin_maps_loop_extra) that invoke dolphin-maps-loop-sweep with the new
Lambda modes from dolphin-maps: seven {"mode": "week", "weekday": X} on the
first Saturday of the month (cron SAT#1), America/Los_Angeles, 20:00, 20:20,
... 22:00 (mon first), and {"mode": "weekend"} on Thursday 23:00. Same
ENABLED/DISABLED switch as the other schedules (dolphin_maps_loop_enabled,
default false), same scheduler role, no retries. None overlaps another, the
Sunday 23:00 sweep or the weekday-morning live loop.
- Header comment and the variable description say what the new schedules are.
- AGENTS.md: the dolphin-maps loops entry mentions them.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex security review |
|
@coderabbitai review |
|
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Schedules for the two new dolphin-maps Lambda modes (dolphin-labs-hq/dolphin-maps PR #346,
weekandweekend; see itsdocs/design/weekday-traffic.md). Both read days of the week the Sunday sweep does not, intoobservations/gmaps_week.csv, which the fit does not read.dolphin-maps-loop.tf: eight newaws_scheduler_scheduleresources (dolphin_maps_loop_extra), all invoking the existingdolphin-maps-loop-sweepfunction (its role, its one-at-a-time concurrency, its failure alarm) through the existing scheduler role:dolphin-maps-loop-week-mon{"mode":"week","weekday":"mon"}-week-tue/-wed/-thu/-fri/-sat{"mode":"week","weekday":X}-week-sun{"mode":"week","weekday":"sun"}dolphin-maps-loop-weekend{"mode":"weekend"}SAT#1. A week pass is 18 jobs (one wave of Browserbase's 25 browsers) and a few minutes; 20 minutes apart means no two overlap. None overlaps the Sunday 23:00 sweep (the last one starts at 22:00 on Saturday), the Monday 00:00 refit, or the weekday-morning live loop; Thursday 23:00 has no other loop.dolphin_maps_loop_enabled(defaultfalse), so they are DISABLED like the other dolphin-maps schedules.AGENTS.md's dolphin-maps loops entry say what the schedules are.deploy-loop.ymlonce PR claude-master: a fifth subscription, claude-thao #346 merges there; invoking the sweep function with them before that fails withunknown mode, so enable the loops only after that deploy.Checked:
terraform fmt -check dolphin-maps-loop.tf; the cron expressions and inputs evaluated in a throwaway local Terraform config (the table above is its output).terraform validate/planneed providers and credentials, so the jumpbox does them on apply.