Repository navigation
fcvm-fleet: host and tile AMIs from ejc3/fcvm main ce08eee9 (renderer keeps every tile inside its slot) - #711
Conversation
… keeps every tile inside its slot) Host fcvm-fleet-host-x86_64-ce08eee9-20261027 and tile fcvm-fleet-tile-x86_64-ce08eee9-20261027, revised from the 2e2181cf images. The renderer draws at the tallest asked height whose frame fits a slot (ejc3/fcvm#1380); the host image also carries ejc3/fcvm#1370 (agent snapshot baked, launch files prefetched).
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex security review |
|
@coderabbitai review |
|
@greptileai review |
|
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Independent HIGH code/security and artifact review passes at 6116657. Both AMIs are available, private, owned by the fleet account and have no external launch grants. CloudTrail and SSM build metadata confirm their builder lineage and source pin; both recipe bundles match all 26 public source files at ce08eee9. Store parts and source CI were verified. Exact-head Codex code/security reviews and required AWS CI pass; no unresolved threads. CodeRabbit is quota-limited and Greptile did not respond; neither is counted as an approval. Both older image commits are ancestors of ce08eee9, so #708 and #710 are superseded. These pins affect future launches; this deployment does not recycle existing hosts. A fresh AMI cold-boot test remains unavailable because of GPU spot capacity, as disclosed in the PR. |
|
The combined deployment is complete at e4e019d. Terraform apply succeeded, followed by a full 2,524-resource plan with exit 0 / no changes. All four live latest launch templates now contain the reviewed images: host version 9 uses ami-022d4bacbe2aeec39; tile/on-demand versions 6 and pool version 3 use ami-0254d5034aa6efece. The deployed coordinator source explicitly selects $Latest in every host and tile launch path. These pins take effect on future launches; existing GPU hosts were not forcibly recycled. Superseded #708 and #710 are closed. |
Host and tile AMIs from ejc3/fcvm main ce08eee9, whose renderer draws at the tallest asked stream height whose frame fits a frame slot (ejc3/fcvm#1380).
Without it, one viewer opening a tile held the whole staging wall to that tile's rate: an opened 16:9 tile asks its renderer for 720 against the wall's 432, and on terrain the 720 frame took 36 ms (render 29 ms) at the lowest budget, so the renderer drew 15 fps and the page, which shows every tile at one scene time, drew the wall at 15 to 24 fps (measured from all 16 streams: 23.8 fps over 21 s with slot-6 opened, 30.1 fps without).
fcvm-fleet-host-x86_64-ce08eee9-20261027(ami-022d4bacbe2aeec39), revised from the 2e2181cf image with main's recipe (fleet/ami/host/build.sh buildandbake; strace installed first, which #1370's prep adds), store parts uploaded under its own prefix (17 PUTs, all 200). The build's warm VM reached its first frame in 21.4 s, the root warm-up VM in 17.1 s (6163 files, 334 MiB to prefetch). It also carries Host AMI: bake the agent's snapshot and prefetch its root volume files fcvm#1370 (agent snapshot baked, launch files prefetched) and #1361 (VUI bitstream_restriction).fcvm-fleet-tile-x86_64-ce08eee9-20261027(ami-0254d5034aa6efece), revised from the 2e2181cf image with main's tile units, renderer image from the host build (samefleet/renderersource).fleet-renderer-testin that image on its T4: 84 checks passed.On the tile builder's T4, the new renderer drawing a 16:9 wall tile of
tools/scene-move.jsonat budget 125,000 with a 432 stream (14.5 ms frames): adding a 720 stream and then a 1080 stream left it drawing at 432 (drawn_h432), 30 fps, 0 slots missed over 24 s each, the taller stream scaled up.measure-boot.shcould not run: no spot g4dn.xlarge or g4dn.metal capacity in any us-east-1 AZ at 08:55 UTC.Supersedes #708 (2e2181cf) and #710 (e15f9e7e): both images' commits are ancestors of ce08eee9. ejc3/fcvm#1383 (renderer clouds and weather keys) merged after ce08eee9 and is not in these images; an AMI built from a later main supersedes this one. The coordinator ejc3/fcvm#1380 needs is deployed (staging coordinator from 12a83dcc, which contains ce08eee9). A renderer without #1383 ignores the scene's
weatherkey.