Skip to content

fcvm-fleet: pin host and tile images from fcvm main e32ad48d - #727

Merged
ejc3 merged 5 commits into
mainfrom
fcvm-fleet-host-ami-097595bc
Oct 31, 2026
Merged

ejc3 merged 5 commits into
mainfrom
fcvm-fleet-host-ami-097595bc

Conversation

@ejc3

@ejc3 ejc3 commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

Pin the host and tile images built from ejc3/fcvm main e32ad48d:

  • host ami-0a63fa06ea592d4c7 (fcvm-fleet-host-x86_64-e32ad48d-202610300823), revised from the 93c33125 image;
  • tile ami-0c6f93b542d72ebcf (fcvm-fleet-tile-x86_64-e32ad48d-202610300834), revised from the 93c33125 tile image with the host build's renderer export, its boot prefetch list traced again.

This PR earlier pinned the afc4894d host image (ami-0d4b40dfa5b467f22) and then the 93c33125 pair (ami-019a97413616788a5, ami-01dbdab881c6f5c2a). Neither was applied, so the jumpbox applies one image set. Over afc4894d these images carry the renderer fixes for the owner's report of a speckled, flat wall:

The page's link-adaptive budget (ejc3/fcvm#1456, std on a link that carries it) is page-only and is already on stage.

Evidence for the e32ad48d images

Built with fleet/ami/build-ami.sh. The host build's own checks:

warm-phone: cold boot ok=1 streaming_ms=52229 gpu=0000:18:00.0
warm-phone: warm snapshot phone-warm in 12582 ms
warm-phone: clone ok=1 click_to_first_scene_frame_ms=6665 gpu=0000:19:00.0

All 16 store parts uploaded with status 200.

fleet/ami/measure-boot.sh host ami-0a63fa06ea592d4c7 (on demand, us-east-1):

fcvm-fleet-vfio active 66407 ms after the request
fcvm-fleet-store active 87407 ms after the request
on-instance: fcvm-fleet-store: mkfs+mount 1408 ms, restore of 16 parts from s3 via tmpfs 22962 ms, 82G apparent
warm: ok=1 first_frame_ms=6362 gpu=0000:18:00.0
snapshot: hit
host: first GPU VM done 107439 ms after the request (includes SSM round trips)

fleet/ami/measure-boot.sh tile ami-0c6f93b542d72ebcf (spot):

tile: request->accepted 2303 ms, ->running (seen) 8663 ms, ->first frame over HTTPS 33698 ms

The first e32ad48d tile image, which kept the earlier image's prefetch list, measured 49.7 s and 44.2 s to first frame. Tracing again (tile/build.sh trace on a boot without the list: 2,333 files, 2,734 pieces, 416.8 MiB) brought it back to 33.7 s, against 33.0 s for the 93c33125 tile and 32 to 37 s for earlier ones.


What the afc4894d image already carried (unchanged from the earlier description of this PR):

Evidence for the afc4894d image

fleet/ami/measure-boot.sh host ami-0d4b40dfa5b467f22 (on demand, us-east-1):

fcvm-fleet-vfio active 66208 ms after the request
fcvm-fleet-store active 89208 ms after the request
on-instance: fcvm-fleet-store: mkfs+mount 3583 ms, restore of 16 parts from s3 via tmpfs 21745 ms, 82G apparent
on-instance: analyze: Startup finished in 7.720s (kernel) + 40.992s (userspace) = 48.713s
on-instance: blame: 25.378s fcvm-fleet-store.service
on-instance: blame:  7.291s cloud-init-local.service
warm: ok=1 first_frame_ms=5959 gpu=0000:18:00.0
snapshot: hit
host: first GPU VM done 115063 ms after the request (includes SSM round trips)

The d8d5f6ad image measured 68.8, 89.8 and 113.1 s for the same three marks.

The build's own checks: the renderer warm-up to first frame (warm: ok=1), the root warm-up as the agent launches a slot (warm-root: launch ok=1), and the phones (host/warm-phone.sh): the cold boot streamed at 51.7 s (the phone image was already in the store), the warm snapshot of the running phone in 12.6 s, a clone on another T4 at its first scene frame 6.5 s after the click (6.6 s on the d8d5f6ad image).

make phone-test on a g4dn.metal launched from this image (fleet/tools/gpubox.sh with GPUBOX_AMI): passed, 102 checks, 0 failures; flow B (a clone on a second T4) at the app's first frame 5.7 s after the click.

Phones on stage also need --phones 2 (#724).

Summary by CodeRabbit

  • Updates
    • Updated the default host and tile images for the US East region. The refreshed images include newer builds and feature updates. This changes the images used by default when setting up hosts and tiles in that region.

ami-0940470cc216e012d: the phones' GPU mirror (fcvm #1432-#1435), the bake
that leaves /tmp empty (fcvm #1444) and the agent's dial deadlines (fcvm
#1445). measure-boot: store active 87.1 s and first GPU VM 108.1 s after the
request, against 116.1 s and 144.1 s on ami-02ac54ae25a2312f9. The tile image
is unchanged.
@ejc3
ejc3 marked this pull request as ready for review October 29, 2026 19:13
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d5e755c4-0750-4d6a-ab05-5d3eb09f34ee
Commits

Reviewing files that changed from the base of the PR and between 239ea90 and 3ff529f.

Files selected for processing: 1
  • fcvm-fleet.tf

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The us-east-1 fleet host and tile AMI defaults changed. Their descriptions now include details about the updated images.

Changes: Fleet AMI updates

Layer / File(s) Summary
Update paired AMI defaults
fcvm-fleet.tf
The host AMI default and description now identify a newer build and its listed contents. The tile AMI default and description now identify its renderer and boot-prefetch list, and retain its readiness checks.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Possibly related PRs

  • ejc3/aws#713: Updates both fleet AMI defaults to a paired renderer image set.
  • ejc3/aws#723: Pins the preceding host and tile AMIs for the fleet.
  • ejc3/aws#698: Pins earlier images for the same host and tile AMI defaults.
Merge Risk: Minimal · up to 3ff52

No merge-blocking risk was identified in this AMI update; proceed with normal infrastructure validation.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: pinning the host and tile AMIs from the specified fcvm commit.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T15:35:35.440420Z 3ff529f Manual request
🔒 Security Review ✅ Completed 2026-10-31T15:39:27.268011Z 3ff529f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Replaces the 097595bc image this PR pinned (never applied) with one built from fcvm main
d8d5f6ad, revised from it: the phones' mirror with zstd on its wire (ejc3/fcvm#1449, which
the stage page now requires) and the streamer's close frame (#1440), the emulator from
ejc3/gfxstream#6 (#1450), and the phone container's fixes (#1448), on top of 097595bc's
image (#1444, #1445). The tile image is unchanged.
@ejc3 ejc3 changed the title fcvm-fleet: pin the host image from fcvm main 097595bc fcvm-fleet: pin the host image from fcvm main d8d5f6ad Oct 29, 2026
Revised from the d8d5f6ad image (not yet applied) with fcvm main afc4894d,
which adds ejc3/fcvm#1453: a dial of a routed VM's published port that
arrived during the VM's teardown held fcvm at exit until the dial of the
dead guest gave up, so a claimed GPU's old VM took 4.2 to 4.8 s to stop on
stage instead of about 0.4 s. On a host launched from this image, SIGTERM
to fcvm exit with a client dialling the port through the stop took 361,
379 and 368 ms. ejc3/fcvm#1451 (page only) is already on stage.
@ejc3 ejc3 changed the title fcvm-fleet: pin the host image from fcvm main d8d5f6ad fcvm-fleet: pin the host image from fcvm main afc4894d Oct 30, 2026
Host ami-019a97413616788a5 (fcvm-fleet-host-x86_64-93c33125-202610300733),
revised from the afc4894d image this PR pinned before: adds the renderer's
speckle fix (ejc3/fcvm#1454). Tile ami-01dbdab881c6f5c2a
(fcvm-fleet-tile-x86_64-93c33125-202610300735), revised from the 67d383ea
tile image with the same renderer export.
@ejc3 ejc3 changed the title fcvm-fleet: pin the host image from fcvm main afc4894d fcvm-fleet: pin host and tile images from fcvm main 93c33125 Oct 30, 2026
Host ami-0a63fa06ea592d4c7 (fcvm-fleet-host-x86_64-e32ad48d-202610300823),
revised from the 93c33125 image; tile ami-0c6f93b542d72ebcf
(fcvm-fleet-tile-x86_64-e32ad48d-202610300834), its boot prefetch list traced
again. Over 93c33125 both add ejc3/fcvm#1455: a word cut by terrain follows
the ground, and its glow no longer draws a bright rim.
@ejc3 ejc3 changed the title fcvm-fleet: pin host and tile images from fcvm main 93c33125 fcvm-fleet: pin host and tile images from fcvm main e32ad48d Oct 30, 2026

ejc3 commented Oct 31, 2026

Copy link
Copy Markdown
Owner Author

@codex review
@codex security review
@coderabbitai review
@greptileai review

Please review current head 3ff529f73882c7d8e3288da68edd03b268fa31ba before the infrastructure apply. Independent code and security reviews are running; live state, credential scope and deployment prerequisites will be checked before applying.

@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 3ff529f738

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ejc3 commented Oct 31, 2026

Copy link
Copy Markdown
Owner Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: 3ff529f738

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@ejc3
ejc3 merged commit ae2e752 into main Oct 31, 2026
3 checks passed

ejc3 commented Oct 31, 2026

Copy link
Copy Markdown
Owner Author

Applied and runtime verified: host LT version 12 and all tile launch templates use the new private images. Real streams and both owner-scoped phone mirrors passed positive and negative auth checks against the new images; private IVS rejects unsigned access and accepts a valid signed manifest. Final full Terraform follow-up is empty on main 1eecb89. The fixed eight-slot FCVM wall intentionally includes two empty waiting_capacity slots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant