fleet: publish the host aggregator under agg-<host>-<token> names by ejc3 · Pull Request #1267 · ejc3/fcvm

ejc3 · 2026-10-25T12:38:21Z

Second of three stacked PRs for #1232. A GPU host's aggregator serves browsers with TLS and the coordinator names it like a slot launch, so AggregateView.frame_url / frame_url_v4 are reachable from the https page.

Stacked on: fix/issue-1232 (#1266). Next: #1268 (EC2 aggregator names).

What changed

Agent, --aggregate-tls-port <port> (needs --aggregate-port and --tls-secret):

runs the aggregator with --tls-file (the renderers' tls.json) and --tls-listen <publish ip>:<port> (the IPv4 path: one address per host, a port per stream), and with an IPv6 prefix also on [<prefix>::1]:443. <prefix>::1 is the host's side of the delegated /80, which fcvm already refuses to give a VM; the agent puts it on the host's default IPv6 interface (ip -6 addr replace <addr>/128 dev <iface> nodad) before it starts. One IPv6 address for the aggregator, as each slot has its own.
reports ipv6, and with --public-ipv4-from-imds ipv4 and v4_port, as new optional fields of the aggregate message.

fleet-core:

Host keeps the reported addresses and its published names. Event::Published for agg-<host> applies only to the addresses the host reports now.
aggregate_id(host): agg-<host> when the host name fits a DNS label (lowercase letters, digits, inner hyphens, at most 40 characters; an EC2 instance id is 19; not ec2).
canonical_ip and Published::names replace the two copies of the canonical address comparison (dns.rs and view::frame_urls).
view: with published names an aggregate's URLs are its published names (wss://agg-<host>-<token>.<zone>/frames, wss://agg-<host>-<token>-v4.<zone>:<port>/frames) once confirmed, else null. Without the DNS writer, the reported URL as before.

Coordinator:

dns::facts includes each host aggregator (generation 0: one launch while its addresses stay the same), so its names go through the same mint, write, confirm and publish path and the same zone setting as slot names. owned() recognises agg-<host>-<token>[-v4]. The write and confirm loop is unchanged.
The poster reads a host aggregator at its published name when it has one (IPv4 first): the URL the agent reported can be an address only that host reaches.

Staging is unchanged until an agent is given --aggregate-port and --aggregate-tls-port (ejc3/aws#671, switch off).

Contract and evidence

a_host_aggregator_is_published_under_its_own_names (tests/test_fleet_coord.rs): an aggregator with no public address gives the page no URL and gets no records; with addresses its AAAA and A records are written, no URL reaches the page before the authoritative check passes, then both names do (the IPv4 one with its port); a new address hides the old URLs at once, publishes new names, and the old records are removed. With the view returning the reported URL it fails: the plain URL reached an https page: {"frame_url":"ws://gpu-a.internal:20300/frames",...}.
the_agent_runs_and_feeds_its_aggregator now runs the aggregator with TLS through the agent: the report carries ipv4 and v4_port, https://.../healthz answers, /layout over TLS is 404.
only_fleet_names_are_owned (agg names in and out, including dnstest-agg-...), labels_are_owned_and_not_reused, a_host_aggregator_is_named_only_when_its_host_name_fits_a_label, a_slot_address_is_the_gpu_index_plus_two_in_the_prefix (<prefix>::1).

make test-unit FILTER="-E 'binary(/test_fleet/) or package(fleet-core) or test(/fleet::/)'"
     Summary [   5.663s] 139 tests run: 139 passed
make lint  # ok

Not exercised here: adding the address on a real host (needs root and a delegated prefix); the unit test covers the address, and add_host_address fails the agent's start with the ip error if it cannot.

Part of #1232.

A host aggregator's stream was reachable only at the plain URL its agent reported, which an https page cannot open, so AggregateView.frame_url was unusable and frame_url_v4 was always null. Agent (`--aggregate-tls-port <port>`, with --tls-secret): - runs the aggregator with --tls-file (the renderers' tls.json) and --tls-listen on <publish ip>:<port>, and with an IPv6 prefix also on [<prefix>::1]:443. <prefix>::1 is the host's side of the prefix, which fcvm never gives a VM; the agent puts it on the host's default IPv6 interface (ip -6 addr replace ... nodad) before it starts. - reports ipv6, and with --public-ipv4-from-imds ipv4 and v4_port, in the aggregate message (new optional fields). fleet-core: - Host keeps the reported addresses and its published names (aggregate_published). Event::Published for `agg-<host>` applies only to the addresses the host reports now. - aggregate_id(host): `agg-<host>` when the host name fits a DNS label. - canonical_ip and Published::names replace the two copies of the canonical comparison (dns.rs, view::frame_urls). - view: with published names an aggregate's frame_url/frame_url_v4 are its published names, else null; without DNS, the reported URL as before. Coordinator: - dns::facts includes each host aggregator (generation 0: one launch while its addresses stay the same), so its names go through the same mint/write/confirm/publish path and zone as slot names; owned() recognises agg-<host>-<token>[-v4]. The write/confirm loop is unchanged. - The poster reads a host aggregator at its published name when it has one: the reported URL can be an address only that host reaches. Staging is unchanged until an agent is given --aggregate-port and --aggregate-tls-port. Tests: - a_host_aggregator_is_published_under_its_own_names (tests/test_fleet_coord.rs): no URL for a plain aggregator, records written, URLs only after confirmation, a new address hides the old URLs and the old records go. With the view returning the reported URL it fails: "the plain URL reached an https page". - the_agent_runs_and_feeds_its_aggregator now runs the aggregator with TLS, checks the reported ipv4/v4_port, https /healthz and 404 for /layout over TLS. - only_fleet_names_are_owned, labels_are_owned_and_not_reused, a_host_aggregator_is_named_only_when_its_host_name_fits_a_label, a_slot_address_is_the_gpu_index_plus_two_in_the_prefix.

coderabbitai · 2026-10-25T12:38:29Z

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 1ca46c31-deb9-4113-9907-b30a7628e3f9

Commits

Reviewing files that changed from the base of the PR and between 7b6ab7b and 578ea4c.

Files selected for processing: 13

fleet/PROTOCOL.md
fleet/core/src/apply.rs
fleet/core/src/protocol.rs
fleet/core/src/state.rs
fleet/core/src/view.rs
src/cli/args.rs
src/fleet/agent/addr.rs
src/fleet/agent/mod.rs
src/fleet/coord/dns.rs
src/fleet/coord/mod.rs
src/network/routed.rs
tests/test_fleet_agent.rs
tests/test_fleet_coord.rs

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

chatgpt-codex-connector · 2026-10-25T12:38:32Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-25T12:41:02.319300Z	`ad48244`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

ejc3 · 2026-10-25T12:39:03Z

@codex review

chatgpt-codex-connector · 2026-10-25T12:41:01Z

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: ad48244853

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ejc3 · 2026-10-25T15:51:52Z

NOT-A-DEFECT: the CodeRabbit comment is a review-limit notice, not a finding.

ejc3 · 2026-10-25T18:59:40Z

NOT-A-DEFECT: the CodeRabbit comment is a review-limit notice. The head is a clean automatic merge of the layer below (its tree equals git merge-tree --write-tree of its parents), so Codex's no-findings review of this PR's previous head covers its own change.

…ggregate # Conflicts: # fleet/PROTOCOL.md # tests/test_fleet_coord.rs

This was referenced Oct 25, 2026

fleet aggregate: serve /frames with TLS on public listeners #1266

Merged

fleet: serve the EC2 half's aggregator to browsers under agg-ec2 names #1268

Merged

Merge branch 'fix/issue-1232' into fix/issue-1232-host-aggregate

450b691

Base automatically changed from fix/issue-1232 to main October 25, 2026 21:39

Merge remote-tracking branch 'origin/main' into fix/issue-1232-host-a…

578ea4c

…ggregate # Conflicts: # fleet/PROTOCOL.md # tests/test_fleet_coord.rs

ejc3 merged commit eccdd6e into main Oct 25, 2026
3 of 4 checks passed

ejc3 deleted the fix/issue-1232-host-aggregate branch October 25, 2026 22:09

Navigation Menu

Repository navigation

fleet: publish the host aggregator under agg-<host>-<token> names - #1267

fleet: publish the host aggregator under agg-<host>-<token> names#1267
ejc3 merged 3 commits into
mainfrom
fix/issue-1232-host-aggregate

ejc3 commented Oct 25, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 25, 2026 •

edited

Loading

Review limit reached

Uh oh!

chatgpt-codex-connector Bot commented Oct 25, 2026 •

edited

Loading

Uh oh!

ejc3 commented Oct 25, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 25, 2026

Uh oh!

ejc3 commented Oct 25, 2026

Uh oh!

ejc3 commented Oct 25, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

ejc3 commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Contract and evidence

Uh oh!

coderabbitai Bot commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

chatgpt-codex-connector Bot commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

ejc3 commented Oct 25, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 25, 2026

Uh oh!

ejc3 commented Oct 25, 2026

Uh oh!

ejc3 commented Oct 25, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ejc3 commented Oct 25, 2026 •

edited

Loading

coderabbitai Bot commented Oct 25, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 25, 2026 •

edited

Loading