Repository navigation
Use the AWS documentation placeholder instance ids in fleet host fixtures - #1336
Conversation
…ures Main's Bench Harness Tests failed test_no_tracked_file_anywhere_names_an_instance_volume_or_host (run 40278845876): the host driver fixtures in src/fleet/coord/hosts.rs and tests/test_fleet_coord.rs used made-up instance ids that match its pattern. They now use i-0123456789abcdef0 and i-1234567890abcdef0, the placeholders the check allows. Tests: the check fails on main and passes here; make test-unit over test_fleet_coord and fleet::coord::hosts passes (76 tests); make lint passes.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Main's Bench Harness Tests failed
test_no_tracked_file_anywhere_names_an_instance_volume_or_host(run 40278845876): the host driver fixtures insrc/fleet/coord/hosts.rsandtests/test_fleet_coord.rsused made-up instance ids that match its pattern. They now usei-0123456789abcdef0andi-1234567890abcdef0, the placeholders the check allows.Tests: the check fails on main (CI log above) and passes here (
python3 -m unittest test_reqbench.NoHostIdentifiersInTree, 3 OK);make test-unitover test_fleet_coord and fleet::coord::hosts passes (76);make lintpasses.Codex: skipped — fixture id substitution only, no behaviour change.