Repository navigation
fleet/web mock: draw the picture without per-pixel allocations - #1339
Conversation
main's Fleet Web job fails since the image went full-bleed (#1331): the two-viewers test waited 30 s for all 15 tiles at one common t and got 11. Measured on the CI runner (4 vCPU, EPYC 7763), the mock renderer was out of CPU: the 960x540 image is 752,640 pixels a frame with the overlap against 335,616 for the old letterboxed one, the mock's node process used 2.0 to 2.9 cores (its 3 render threads), it dropped frames from the first test (54 skipped, 22 renders queued), and by the end a single viewer synced 12 of 15 in 45 s. Two viewers share each render; the test failed there because by then the mock was behind for everyone. shade() built a closure for the planet's ring on every pixel, and the chroma loop built an array of four offsets for every sample. Both are inlined; the arithmetic and its order are unchanged. One frame of the 960x540 image takes 98.7 ms on one core here instead of 137.8 ms. With it, the same runner went through all 50 Chromium tests: every openWall synced in 0.9 to 3.0 s, and the mock used about 2.2 cores. - mock/test/pattern.test.ts: renderI420's output for three tiles (planet, both sides of the ring, a word, a light, the clock) hashes the same as before the change. - scripts/mock-render-cost.ts: what one frame of a window's image costs and how many cores that is at a frame rate. - e2e/helpers.ts: openWall prints the mock's render stats when it times out, so the next such failure says whether the mock kept up. - ci.yml: the Fleet Web job's comment states the measured budget.
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 49 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
main's Fleet Web job has failed since #1331 made the image full-bleed:
e2e/wall.spec.ts:541(two viewers) waited 30 s for all 15 tiles at one common t and got 11 (run 40278845876). The same failure hit #1332's runs (13 of 15; and "switching streams" never finished its switch), which I missed before merging.Cause, measured on the CI runner. I ran the Fleet Web job unchanged on a throwaway branch with a CPU sampler and a per-
openWalllog (runs 40281499832 and 40282522751; runner: 4 vCPU, AMD EPYC 7763).Change.
shade()built a closure for the planet's ring on every pixel, andrenderI420's chroma loop built an array of four offsets for every sample. Both are inlined, with the arithmetic and its order unchanged. One frame of the 960x540 image: 137.8 ms on one core before, 98.7 ms after (node scripts/mock-render-cost.ts 960 600 10, this box).Evidence
mock/pattern.tschanged: all 50 Chromium tests passed, everyopenWallsynced in 0.9 to 3.0 s, mock about 2.2 cores, no render backlog.mock/test/pattern.test.ts: the picture is byte for byte the same (hashes of three tiles covering the planet, both sides of the ring, a word, a light and the clock, taken from main'spattern.ts).pnpm lint && pnpm typecheck && pnpm test(224) andpnpm test:e2e(56 passed).Also
e2e/helpers.ts:openWallprints the mock's render stats when it times out, so a future timeout says whether the mock kept up.scripts/mock-render-cost.ts: what one frame of a window's image costs and how many cores at a frame rate.ci.yml: the Fleet Web job's comment gives the measured budget (it still described the letterboxed image).Downstream impact. Test infrastructure only: the mock fleet and the CI job's comment. The page is unchanged.