fix(ep-commerce): provide FormProvider from EP Product Provider - #409
Open
mzaintariq wants to merge 1 commit into
Open
fix(ep-commerce): provide FormProvider from EP Product Provider#409mzaintariq wants to merge 1 commit into
mzaintariq wants to merge 1 commit into
Conversation
Match commerce Product Box so location/variant/quantity form state is shared with Add To Cart; without it, EPLocationPicker clicks are no-ops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this MR do?
Mounts a react-hook-form
FormProviderinsideEPProductProvider, matching commerce Product Box’s contract. Without it, descendants that write selection via form context (SelectedLocationSlug, variants, quantity for ATC) silently no-op when the PDP uses EP Product Provider instead of Product Box.Changes
FormProviderfromuseForm()ProductProviderDesign decisions
FormProvider; this closes the gap for compositions that only use EP Product ProviderTesting
Reviewer notes