Add a eager fetcher and fan-out fetch of parity shards on slow reads - #4
Open
jhindersson wants to merge 3 commits into
Open
jhindersson wants to merge 3 commits into
jhindersson wants to merge 3 commits into
Conversation
…6-33322 - CVE-2026-41145: only accept Authorization header credentials for STREAMING-UNSIGNED-PAYLOAD-TRAILER auth type. - CVE-2026-40344: add missing authTypeStreamingUnsignedTrailer handling in PutObjectExtractHandler (Snowball auto-extract). - CVE-2026-34204: ignore X-Minio-Replication-* SSE metadata headers on non-replication PutObject/PostPolicy requests. - CVE-2026-33322: restrict OIDC JWT ValidMethods to algorithms advertised by the provider, defaulting to asymmetric only, and only register the client secret as HMAC key when HMAC is advertised. Includes regression tests for all four CVEs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configurable hedged erasure reads to alleviate horrendous cluster performance on dying HDDs (1-30s read latency).
Configurable with
mc admin config set <alias> drive.read_fanout_delay=250ms. 0=disabledWhen enabled the cluster read K+1 shards to answer client instantly even though one disk is slow. If the request takes more than read_fanout_delay a full fanout is made for the rest of the parity shards to answer the client as quickly as possible.
Adds minimal to no overhead, read buffer is always sized to fetch all shards anyway. Most drives in the erasure set are active anyway so the extra read penalty is a negligible 100/K % extra network overhead which is totally irrelevant on a HDD backed server with 10Gbit+ network where performance will be mostly IOPS bound (pushing 2-3Gbit per server with 12 drives is considered good unless we are doing fully sequential workloads, fully random 4k workload will max out at 200Mbit per server). Also CPUs are mostly idle in a HDD IO constrained server so we have LOTS to spare for reconstructing data from parity.