USBD Conf - User String Desc macro update - #702
Merged
Conversation
…match Middleware expectations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated USBD_SUPPORT_USER_STRING to USBD_SUPPORT_USER_STRING_DESC to match Middleware expectations.
Looks like this was updated in the HAL a long time ago, and we never updated our local conf to match.
This is required for the bootloader repo's big libDaisy upgrade PR so that it can start using libDaisy's middleware instead of carrying its own.
The conf template from the version of the middleware we're checking out has a few other differences.
So might be worth taking a look if there is anything else worth updating in ours at some point, but I'm intentionally keeping this minimal for the time being.