Cleanup: Lose unused methods in PluginManager#1769
Open
jeremypw wants to merge 4 commits into
Open
Conversation
This reverts commit 33372eb.
- Update pastebin according and fix bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two methods are currently unused and seem out of place in the PluginManager as plugins themselves have access to the current window and document.
Also it is not necessary for PluginManager to hold a reference to "window" for the same reason. For simplicity the pastebin plugin only adds a button to the primary window.
A small bug is fixed in passing whereby when a plugin is activated when there is already an active document that document does not immediately get registered with the plugin (only after focusing another document and returning)
These changes are aimed at making PluginManager a singleton accessible with a
get_default ()function rather than being a member of window (with a reverse reference)