Conversation
lenemter
force-pushed
the
lenemter/rework-cleanup
branch
from
October 3, 2026 14:54
5463d76 to
03be5cd
Compare
Member
Author
|
@utf-4096 Could you check if this solves the crash please? |
|
No change, unfortunately. I tested in a new VM that I updated and installed this branch on. 2026-10-03.17-42-13.mp4One thing I missed in my reproduction instructions is that the audacious Qt backend needs to be running through Xwayland, the native Wayland driver does not give a crash for some reason. |
lenemter
force-pushed
the
lenemter/rework-cleanup
branch
from
October 3, 2026 21:43
03be5cd to
af275f6
Compare
leolost2605
requested changes
Oct 3, 2026
leolost2605
left a comment
leolost2605
left a comment
Member
There was a problem hiding this comment.
Makes sense but it seems like something keeps a reference on the clone while dragging even after its window was unmanaged. This will cause lots of warnings to appear when a window is unmanaged while you are dragging it and the cursor also shows still as dragging because the drag doesn't get cancelled :/
(You can use sleep 5 && killall yourapp for testing.)
lenemter
force-pushed
the
lenemter/rework-cleanup
branch
from
October 4, 2026 09:07
af275f6 to
2cc5e89
Compare
lenemter
marked this pull request as draft
October 4, 2026 13:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigating #2934
I think we don't need to handle
Meta.Window.unmanagednow. Historically it was needed becauseWindowClonewas destroying itself onunmanaged, but right nowWindowCloneContainerdestroys it instead.